fix(realsense): move validator to 0.21, matching every other crate - #3868
fix(realsense): move validator to 0.21, matching every other crate#3868mustafab0 wants to merge 1 commit into
Conversation
dimos-module, the ray tracing mapper and the mls planner all moved to validator 0.21; the realsense crate was left on 0.20. Both end up in its dependency graph, so its Config derived Validate from 0.20 while Module::Config wanted 0.21 and cargo check failed on an unsatisfied trait bound. Every other Cargo.toml in the repo declares the same "0.21" string -- there is no workspace dependency table to inherit from -- so this aligns realsense with that convention rather than loosening its constraint. This blocks any blueprint composing RealSenseCamera, which is now every hardware grasping run.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3868 +/- ##
=======================================
Coverage 77.64% 77.64%
=======================================
Files 1323 1323
Lines 125419 125419
Branches 10911 10911
=======================================
Hits 97384 97384
Misses 24890 24890
Partials 3145 3145
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Greptile SummaryUpdates the RealSense Rust workspace to use Confidence Score: 4/5Not safe to merge until the RealSense workspace lockfile supports locked Cargo resolution. Isolated execution reproduced Cargo's lockfile-update failure for the changed workspace and showed that regenerating the lockfile allows locked metadata resolution. Files Needing Attention:
What T-Rex did
|
aclauer
left a comment
There was a problem hiding this comment.
Yeah I have a PR that is fixing this with workspace level dependencies for all these things that are shared by all native modules. Right now this module isn't in the top workspace, so it's a bit annoying but fix is coming.
Looks good to unblock!
Actually can you double check greptile on the Cargo lock? Just check that it's regenerated and updated i guess, ping me when ready
dimos-module, the ray tracing mapper and the mls planner all moved to validator 0.21; the realsense crate was left on 0.20. Both versions end up in its dependency graph, so its
ConfigderivedValidatefrom 0.20 whileModule::Configwanted 0.21, andcargo checkfailed on an unsatisfied trait bound. This blocks any blueprint composingRealSenseCamera, which is now every hardware grasping run.Every other
Cargo.tomlin the repo declares the same"0.21"string and there is no workspace dependency table to inherit from, so this aligns realsense with that convention rather than loosening its constraint. Reproduced the failure by putting 0.20 back (error[E0277]: required for <RealSense as Module>::Config to implement ModuleConfig) and confirmedcargo checkis clean on 0.21; the lockfile is consistent under--locked.First of nine in the xArm grasping re-landing stack.