Skip to content

Redaction: an sk- key right after a hyphen #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepfates merged 2 commits into from
Sep 28, 2026
+4 −2
Merged

Redaction: an sk- key right after a hyphen #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b0c4d
Redaction: an sk- key right after a hyphen
deepfates Sep 28, 2026
54cb7b4
Merge branch 'main' into claude/sk-after-hyphen
deepfates Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/imp/redaction.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,8 +917,9 @@ defmodule Imp.Redaction do
# encrypted), a PGP private key block, a PuTTY key file.
~r/-----BEGIN [A-Z0-9 ]{0,40}PRIVATE KEY(?: BLOCK)?-----/,
~r/PuTTY-User-Key-File-[0-9]+:/,
# OpenAI (`sk-`, `sk-proj-`), Anthropic (`sk-ant-`), OpenRouter (`sk-or-`).
~r/(?:\A|[^A-Za-z0-9_-])sk-[A-Za-z0-9_-]{8,}(?=\z|[^A-Za-z0-9_-])/,
# OpenAI (`sk-`, `sk-proj-`), Anthropic (`sk-ant-`), OpenRouter (`sk-or-`),
# also right after a hyphen (`x-sk-...`), as a word boundary allows.
~r/(?:\A|[^A-Za-z0-9_])sk-[A-Za-z0-9_-]{8,}(?=\z|[^A-Za-z0-9_-])/,
# Stripe secret and restricted live keys.
~r/(?<![A-Za-z0-9_])[sr]k_live_[A-Za-z0-9]{16,}(?![A-Za-z0-9_])/,
# GitHub classic, OAuth, user-to-server, server and refresh tokens, and
Expand Down
1 change: 1 addition & 0 deletions test/redaction_differential_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ defmodule Imp.RedactionDifferentialTest do
sk = "sk-FAKEopenai" <> String.duplicate("a1", 12)

[
{"key after a hyphen", "flag x-#{sk} set\n"},
{"printenv",
"HOME=/root\nOPENAI_API_KEY=#{sk}\nSECRET_KEY_BASE=FAKEskbQQQQQQQQQQQQ\nPGPASSWORD=FAKEpgpass99\nRELEASE_COOKIE=FAKEcookie\nSTRIPE_KEY=FAKEstripeplain\n"},
{"curl -v",
Expand Down
Loading