Redaction: an sk- key right after a hyphen - #247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the fact-check of the 0.6.0 draft (#246). 0.5.0's
Imp.ExternalCommandhidx-sk-…in command output: its own\bsk-replacement treated a hyphen as a word boundary. The one pattern set that replaced it (#226) required that no letter, digit,_or-come beforesk-, soflag x-sk-… setcame back unredacted.The pattern now allows a hyphen before
sk-. The command-output differential intest/redaction_differential_test.exsgains the case. With the old pattern that test fails ("key after a hyphen showed what the previous pipeline hid"); with the new one it passes.mix format --check-formatted: clean.