[denik]

Changes

validate:required and validate:enum now run generated typed walkers (bundle/config/validate/{required,enum}_walk.go) instead of matching every node of the dyn tree against a trie built from the generated pattern tables. The walkers only go down the pattern paths of the typed config.

The typed config can't tell unset from null, zero or a pure ${...} reference, and it has no locations. For those, each walker node also follows the dyn.Value at its path. This bridge lives in one file, walk_node.go, and gets replaced once config no longer uses dyn.

This is a slice of #7098 (#7098). libs/dyn stays in place.

Behavior

No change: same diagnostics, wording, paths, locations and ordering. Enum diagnostics are first put in dyn-walk order so that ties in the existing sort come out as before.

Tests

• New unit tests in walk_test.go.
• All TestAccept/bundle acceptance tests pass with unchanged goldens. During that run a temporary check (not committed) compared every result with the old trie implementation and found no mismatch.
• The same check passed on 16k randomly mutated acceptance configs (null/""/0/false/{}/[]/refs).

Benchmarks

1000 jobs (bundletest.Bundle), median of 6 runs, macOS M-series, load ~5:

	main	this PR
Required().Apply	41.0 ms	20.7 ms
Enum().Apply	23.0 ms	4.0 ms
BenchmarkValidateRequired1000 (via bundle.Apply)	133 ms	113 ms
BenchmarkValidateEnum1000 (via bundle.Apply)	114 ms	95 ms
bundle validate end to end, acceptance/bundle/benchmarks --jobs 1000	11.12 s	11.04 / 11.18 s

The required check is now dominated by the unchanged sortDiagnostics (it calls fmt.Sprintf in the comparator). End-to-end bundle validate shows no measurable difference: these two mutators are under 1% of it.

This pull request and its description were written by Isaac.

[eng-dev-ecosystem-bot]

Integration test report

Commit: 229ccd4

Run: 41434155626

	Env	🔄​flaky	✅​pass	🙈​skip	Time
✅​	aws linux-2core-8gb		281	15	4:20
✅​	aws-windows-latest-4core-16gb		283	13	3:54
🔄​	azure linux-2core-8gb	2	278	15	4:19
✅​	azure-windows-latest-4core-16gb		282	13	3:41
✅​	gcp linux-2core-8gb		281	15	4:40
✅​	gcp-windows-latest-4core-16gb		283	13	3:48

	Test Name	azure linux-2core-8gb
🔄​	TestFsCpDirToDirWithOverwriteFlag	🔄​f
🔄​	TestFsCpDirToDirWithOverwriteFlag/local_to_uc-volumes	🔄​f

Top 3 slowest tests (at least 2 minutes):

duration	env	testname
3:47	aws-windows-latest-4core-16gb	TestAccept
3:41	gcp-windows-latest-4core-16gb	TestAccept
3:35	azure-windows-latest-4core-16gb	TestAccept