Skip to content

acc: record main's behaviour for reference, override and required-field edge cases - #7130

Merged
denik merged 11 commits into
mainfrom
denik/acc-record-main-behaviour
Oct 28, 2026
Merged

denik merged 11 commits into
mainfrom
denik/acc-record-main-behaviour

Conversation

@denik

@denik denik commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Add four acceptance tests that record how main handles edge cases of references, overrides and required fields:

  • override/cluster_id_clears_new_cluster_reference
  • override/preset_clears_forced_schedule_reference
  • resource_deps/whole_map_reference_hides_entries
  • validate/required_struct_reference

Why

Records today's behaviour before it changes in #7098, so that PR's diff shows what moves.

Tests

Goldens generated on main.

This pull request and its description were written by Isaac.

@github-actions github-actions Bot added the DABs DABs related issues label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 5c12fafe3 | Workflow run

Regression test report

Selected 7 changed tests (limit=20, 0 not selected)

14 tests: regression=0 unreleased=0 coverage=14 failing=0

test branch main (35ed095) latest (v1.22.1)
TestAccept/bundle/override/cluster_id_clears_new_cluster_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/override/cluster_id_clears_new_cluster_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/override/preset_clears_forced_schedule_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/override/preset_clears_forced_schedule_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/presets/name_prefix_reference_to_name/DMS= ✅ ✅ ✅
TestAccept/bundle/presets/name_prefix_reference_to_name/DMS=true ✅ ✅ ✅
TestAccept/bundle/resource_deps/preset_tags_not_applied_to_whole_map_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/resource_deps/preset_tags_not_applied_to_whole_map_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/validate/references/job_schedule_whole_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/validate/references/job_schedule_whole_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/validate/references/job_trigger_whole_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/validate/references/job_trigger_whole_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/validate/required_struct_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/validate/required_struct_reference/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 5c12faf

Run: 40698000937

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 281 22 7:13
🔄​ aws-windows-latest-4core-16gb 2 281 20 4:06
✅​ azure linux-2core-8gb 280 22 5:11
🔄​ azure-windows-latest-4core-16gb 2 280 20 3:43
✅​ gcp linux-2core-8gb 281 22 5:36
✅​ gcp-windows-latest-4core-16gb 283 20 5:16
Test Name aws-windows-latest-4core-16gb azure-windows-latest-4core-16gb
🔄​ TestFsCpDirToDirFileNotOverwritten 🔄​f ✅​p
🔄​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_uc-volumes 🔄​f ✅​p
🔄​ TestFsCpFileToFileWithOverwriteFlag ✅​p 🔄​f
🔄​ TestFsCpFileToFileWithOverwriteFlag/uc-volumes_to_local ✅​p 🔄​f
Top 6 slowest tests (at least 2 minutes):
duration env testname
5:09 gcp-windows-latest-4core-16gb TestAccept
3:46 aws linux-2core-8gb TestAccept
3:24 azure-windows-latest-4core-16gb TestAccept
3:23 aws-windows-latest-4core-16gb TestAccept
2:53 gcp linux-2core-8gb TestAccept
2:52 azure linux-2core-8gb TestAccept

@denik
denik force-pushed the denik/acc-record-main-behaviour branch from cf81f27 to 5c12faf Compare October 28, 2026 13:34
@denik
denik marked this pull request as ready for review October 28, 2026 14:09
@denik
denik requested review from a team as code owners October 28, 2026 14:09
@denik
denik requested a review from lennartkats-db October 28, 2026 14:09
@denik
denik enabled stacked auto-merge October 28, 2026 14:12
stacked auto-merge was automatically disabled October 28, 2026 14:14

Replaced by a newer auto-merge request

@denik
denik enabled stacked auto-merge October 28, 2026 14:14
@denik
denik added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 51afc3b Oct 28, 2026
27 checks passed
@denik
denik deleted the denik/acc-record-main-behaviour branch October 28, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants