Repository navigation
bundle: point at DATABRICKS_BUNDLE_ENGINE in the terraform removal error - #6951
Merged
Merged
Conversation
When only the env var asks for terraform, the error told users to remove the bundle.engine setting, which they don't have. Name the env var instead. bundle.engine takes priority, so it is still the one named when both are set. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Rename TerraformRemovedDetail/Message to TerraformRemovedConfigDetail/Message to pair with the Env variant, and show in engine-config-valid that the config setting is named when both bundle.engine and the env var say terraform. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/engine-env-message
branch
from
October 6, 2026 17:28
35b4340 to
ea2f8fb
Compare
denik
marked this pull request as ready for review
October 6, 2026 17:38
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 6, 2026 17:38
Collaborator
Integration test reportCommit: e9c9f28
Top 6 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 6, 2026
The removal error is new in the unreleased 1.20.0, so there is no released behaviour to describe as changed. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
DATABRICKS_BUNDLE_ENGINE=terraformand nobundle.enginein the config, the Terraform removal error told users to remove thebundle.enginesetting. It now tells them to unset the env var.bundle.enginetakes priority over the env var, so it is still the one named when both are set to terraform.This pull request and its description were written by Isaac.