Repository navigation
Improve large validator batches, update Node to 24.22.3, disable builder config - #448
Merged
Merged
Conversation
UI and API validator operations now give up before the RPC timeout instead of running after the caller has stopped waiting. Updates and builder config reads resolve stored pubkeys regardless of hex casing, and reload tolerates a short signer delete response.
Import runs in batches of 20 with live progress, stop and retry; each batch carries only its own slashing history. The Brain pushes a validatorsChanged event after every database write so open lists refresh themselves, and the list keeps refreshing while rows are marked detailsPending, without blanking the table. Fee checks are cached like beacon data so large lists converge. Signer imports get a 10 minute timeout, fee recipients are applied with bounded concurrency on import and reload, and the import form pages its keystore cards and points at files that still need input.
Covers the HTTP/2, TLS, HTTPS, zlib and permission model fixes published on 2026-11-11 (https://nodejs.org/en/blog/vulnerability/november-2026-security-releases).
A failed call left the subscription map unset, so every live refresh round while validator details were loading queried the oracle again.
Gate the Gloas builder feature behind featureFlags.builderConfig (off): the UI hides builder settings, builder RPCs and update fields are rejected, reload no longer replays stored overrides, and BUILDER_IDS is ignored without consuming its one-time import. Stored builder settings are kept so the feature can be re-enabled without migration.
Run the real UI server, RPC handler, database, lock, reload and API clients against fake web3signer, validator client and beacon node HTTP servers, and drive them over Socket.IO with the UI's own RpcClient and batch import code. Covers batched import of 120 keys, a failed batch with retry, per-key signer rejections, live validatorsChanged pushes, progressive list loading past the 10s deadline, and builder configuration staying disabled. yarn test now runs them in CI.
- Capture the previous rows before scheduling the selection update, so a live refresh cannot move the selection onto a different validator. - Size import batches by exact encoded bytes, including each key's slashing history; report a key too large for any request instead of stopping. - Hold change notifications while a validator operation runs and send one when it finishes, so other UIs refresh after clients are configured. Reload also announces validator-client membership repairs.
…n store Restore the validator-client behavior from main: sequential writes in import, update, delete cleanup and reconciliation, fee-recipient correctness from getFeeRecipient() reads, and live signer/validator membership reads on every list request, reported as unavailable when they fail. - getValidators reads membership and fee recipients within a 10s budget and 8 parallel reads. Cut-off reads are pending and the cursor advances on dispatch, so follow-up requests continue past hung keys. Matching fee checks are cached for 60s only alongside a current membership read; mismatches are dropped on change notifications, reads overlapping a change are not cached, and keys absent from the client lose their cached check. - BeaconStatusStore holds beacon details only, fetched in chunked bulk requests by its own cron job (separate from reconciliation and its lock), looked up for new keys on database changes, and persisted as indexes. - Exits look up indexes with chunked bulk requests. - The UI keys grid rows by pubkey and passes selected validators to dialogs; it requests the list again only while reads were cut off (bounded, coalesced), waits for pushes for beacon details, and shows errors with Retry instead of polling. - Launchpad fee-recipient routes read stored values directly; busy lock errors return 503.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the experience for large validator batches, fixes issues found while reviewing last month's changes, updates Node for the November 2026 security release, and switches off the builder configuration feature for now. Validator-client writes and fee-recipient checks keep the behavior they have on
main; the intentional behavior changes are listed below.Changes
Importing large batches
Listing large sets of validators
getFeeRecipient(), within a 10s budget and 8 parallel reads. Reads cut off by the deadline are markeddetailsPending; the read cursor advances on dispatch, so follow-up requests continue past keys that hang. Failed reads are reported indetailsErrorinstead of reusing an earlier result.BeaconStatusStorefetches index and withdrawal credentials with chunked bulk requests (500 keys) on its own cron job, separate from reconciliation and its lock, and looks up new keys when the database changes. Indexes are saved to the database, so the Brain API'sformat=indexlist includes validators imported since the performance cron was disabled.validatorsChangedSocket.IO event after validator changes (debounced 500ms). Notifications are held while an operation holds the validator lock and sent once it finishes, so other UIs refresh after clients are configured.Review fixes
Node security release
24.22.1→24.22.3inDockerfile,Dockerfile.brain.dev,.nvmrc, CI andengines, for the November 2026 security releases (16 CVEs, 7 High, in HTTP/2, TLS, HTTPS, zlib and the permission model). The Brain does not use HTTP/2, TLS servers or the permission model; its only TLS use is outgoinghttpsrequests to the validator client and signer.Builder configuration disabled
featureFlags.builderConfig = falseinpackages/common/src/featureFlags.ts.builderConfigin updates are rejected, reload does not replay stored overrides, andBUILDER_IDSis ignored without consuming its one-time import.Behavior changes to be aware of
POST /eth/v1/beacon/states/head/validatorsrequests instead of per-validator lookups; the beacon job runs at startup (reads only) and every minute. Reconciliation keeps its existing schedule and makes no beacon calls.main; they stay sequential.Testing
yarn lint,yarn format:check,yarn buildandyarn testall pass (common 13, brain 107 unit + 9 e2e, UI 59).packages/brain/test/e2e): the real UI server, RPC handler, database, lock, reload job and API clients run against fake web3signer, validator client and beacon node servers, driven over Socket.IO with the UI's ownRpcClientand batch import code. Scenarios: batched import of 120 keystores, a failed batch with retry, per-key signer rejections, live pushes to a second UI, a final push after slow validator-client writes, 600 validators listed with beacon details arriving by push, unreachable beacon node and validator client reported as errors and recovering, reload repairing a client that lost its keys, and builder configuration staying disabled.node:24.22.3-alpine3.24(arm64, locally).