Repository navigation
Keep reload restoring fee recipients, refresh UIs after repairs, show import and delete progress - #449
Merged
Conversation
Signer cleanup and adding or removing validator-client keys no longer abort the reload pass, so fee recipients are restored even when cleanup keeps failing; failed removals stay listed and are retried. The signer listing, database pruning and validator-client listing still stop the pass. When the last validator list showed a problem (a fee mismatch, a failed or unfinished read), a completed reload pass now announces itself, so idle UIs list again and re-check fee recipients by GET. Clean passes stay silent.
Imports report validators as importing or queued while running and only call them not attempted once a run stops; the progress bar shows the batch in flight. Deletes run in batches of 25 with the same progress view, stop and retry, and merge every batch's slashing protection export into one download without dropping any. Import and delete share one batch runner and one progress view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two reconciliation gaps found by a recovery audit of 0.2.0-rc.1, and improves progress feedback for large imports and deletes based on testing rc.1 on a Hoodi node with 300 keystores.
Changes
Reload keeps configuring validators when cleanup fails (
445bf93)Fee-only repairs refresh idle UIs (
445bf93)validatorList/readState.tsso reload can use it. A matching fee check is still cached for up to 60s.Batch progress for imports and deletes (
b42e613)batchRunner.ts) and one progress view (BatchProgressView.tsx).Testing
yarn lint,yarn format:check,yarn buildandyarn testpass (common 13, brain 111 unit + 10 e2e, UI 65).