Fix "TEMP NAME of" when a parenthesized matrix is raised to a power (#762) - #763
Open
wittjeff wants to merge 1 commit into
Open
Fix "TEMP NAME of" when a parenthesized matrix is raised to a power (#762)#763wittjeff wants to merge 1 commit into
wittjeff wants to merge 1 commit into
Conversation
…a power is not read as "TEMP NAME of" The mrow 'matrix' intent rule replaces with a bare `x: "*[2]"`, so its result is wrapped in the internal TEMP_NAME transport element; the parent `power` rule's `x: "*[1]"` wraps it again and lift_children only stripped one level. The leftover wrapper reached the generic function-intent speech rule, which spoke its name: "TEMP NAME of the 2 by 2 matrix; ...; squared" (daisy#762). lift_children now flattens nested wrappers recursively. A leaf wrapper holding text is still only unwrapped as a direct child, matching the previous behavior. Two regression tests added to tests/Languages/en/mtable.rs; no goldens changed. Fixes daisy#762 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U86v5m1m8oaLSy5UsNbBpc
Collaborator
|
hi, thanks for your contribution. I have not yet worked much with the intent tree, let alone TEMP_NAME, so it will take me a bit to read into this to review the PR. not sure how busy @NSoiffer is at the moment ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #762.
A parenthesized matrix as the base of
msupwas spoken as "TEMP NAME of the 2 by 2 matrix; row 1; 1, 2; row 2; 3, 4; squared". The LuaLaTeXmspace/fence attributes in the report are not the cause: a plain<msup><mrow><mo>(</mo><mtable>…</mtable><mo>)</mo></mrow><mn>2</mn></msup>reads the same, and canonicalization yields a clean( mtable )mrow in both cases.The intent tree is
power( TEMP_NAME( matrix(…) ), 2 ).TEMP_NAMEis the internal transport wrapperreplace_nodes_treeputs around a barex:replacement. The mrowmatrixintent rule replaces withx: "*[2]"(not anintent:), so the mrow's result isTEMP_NAME(matrix); thepowerrule'sx: "*[1]"wraps it again, andlift_childrenonly stripped one level. The leftover wrapper then reaches the generic function-intent speech rule, which speaks its name.Change:
lift_childreninsrc/speech.rsnow flattens nested wrappers. A wrapper whose children are all elements is spliced recursively; a leaf wrapper holding text (from a Text or Attribute node) is still only unwrapped when it is a direct child, so that path behaves as before.Tests: two regression tests added to
tests/Languages/en/mtable.rs(matrix_raised_to_power, plus the exact MathML from the issue). No goldens changed.cargo test: 1982 + 5106 passed, 0 failed.Both now read:
the 2 by 2 matrix; row 1; 1, 2; row 2; 3, 4; squared. The commented-out Greek corpus cases mentioning "TEMP NAME του … πίνακας" (matrix inverse / powers) are likely the same defect.🤖 Generated with Claude Code
https://claude.ai/code/session_01U86v5m1m8oaLSy5UsNbBpc