FEC - 1227 -> 1232 -> Percy to Chromatic - #3295
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3c56779 to
6d2a63a
Compare
tylermorrisford
left a comment
There was a problem hiding this comment.
claudito had nits but none of them rose to the level of needing to be addressed. Beauty!
|
@tylermorrisford let claudito know i have a few nits of my own for him! |
Build results: https://www.chromatic.com/build?appId=6a6cf2304a0c917990e1a8aa&number=22
Converts 25 Percy visual routes into Storybook stories that Chromatic captures.
The goal is parity: the same states, same props and same order the Percy routes already have, so Chromatic can take over without changing what is covered.
Description
icons,spacings,dropdown-menu— the unconventional routesEach component gains an
AllVariantsstory appended to its existing stories file, taggedvrtand opted into capture withchromatic: { disableSnapshot: false }. Demo stories are untouched and stayuncaptured.
Parity, not new coverage. States whose
percySnapshotis commented out are skipped — no baseline exists for them today, so converting them would add coverage rather than migrate it.Nothing Percy is deleted. Route files, specs and the Percy CI step all stay until parity is signed off.
Deliberate deviations from Percy
iconscolor stories are hidden from the sidebar with!dev; Chromatic still captures them.Follow-up
A final cleanup round happens once all snapshots are gathered. Presentation details are deliberately not being polished component by component: label formatting and alignment, whether the demo stories fold into the captured set, and the Percy teardown all land in one pass at the end, when the full set of baselines exists to judge them against.