FEC - 1237 - 1246 Chromatic wrap up - #3296
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
tylermorrisford
left a comment
tylermorrisford
left a comment
There was a problem hiding this comment.
The theme-provider.spec.tsx is a genuinely good test file — covers the DOM-writing behavior, scoped vs root targeting, overrides, custom properties, and the MutationObserver-based reactivity all in one place. A lot of care went into this one.
Two nits inline.
|
|
||
| | | Percy `Spec` | `VisualSpec` | | ||
| | -------------------- | ---------------------------------------- | -------------------------- | | ||
| | Layout | column: label bar, prop table, component | row: component, then label | |
There was a problem hiding this comment.
Should we update this? The table still says "row: component, then label" but visual-spec.tsx now renders a column with the label on top. The old description matched the grid layout; the new one is flex-direction: column with <Label> before <Box>.
| unlike its four siblings which use boolean. The component only does | ||
| `if (!this.props.isReadOnly)`, so this object is truthy and renders | ||
| exactly as the route file's `true` did. */ | ||
| isReadOnly={{ exact: true }} |
There was a problem hiding this comment.
The comment explains this well — just flagging it so we don't lose track. CreatableSelectField types isReadOnly as ConstrainBooleanParameters while its four siblings use a plain boolean. Worth a follow-up ticket to align the prop type, separate from this migration.
2 participants
ui-kit's VRTs run on Percy, and we're replacing it with Chromatic.
Each
*.visualroute.jsx+*.visualspec.jspair becomes a captured Storybook story.Though some questionable presentation tweaks were made, this migration is PARITY ONLY. Same states, same props, same order, so Chromatic takes over w/o changing what's covered.
This is the last conversion batch that includes the remaining fields, inputs and stragglers, plus theme-provider.
It also tightens the Chromatic comments and skill docs.
The numbers aren't 1:1 for reasons, but every live Percy snapshot now has a story.
Percy is running concurrently, nothing is deleted at this time.
References: