Repository navigation
feat(audio): play an original stage-clear stinger on the platformer results #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
hoppys-adventure-arcade/Assets/Audio/Platformer/PROMPTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Platformer stage-clear stinger | ||
|
|
||
| Music by Erik Thorelli, made with Suno v6 on his Premier plan for Hoppy's Adventure Arcade. Erik holds the rights and grants their use in the game and in this repository. The soundtrack plan is [`docs/soundtrack.md`](../../../../docs/soundtrack.md); level music has its own `PROMPTS.md` in each level's folder. | ||
|
|
||
| | File | Plays | Suno song | Measured | Length | | ||
| |---|---|---|---|---| | ||
| | `stinger_stage_clear.ogg` | Once, when any platformer level finishes and the MERGE SUCCESSFUL results open (`modes/platformer/level.gd`, `_finish(true)`) | [`73fc8220-4010-43da-b82f-95e63862062e`](https://suno.com/song/73fc8220-4010-43da-b82f-95e63862062e) | F major, the theme's key, at 116 BPM | 4.74 s, one-shot | | ||
|
|
||
| ## Prompt | ||
|
|
||
| Suno Sounds, One-Shot, BPM 116, key F major: | ||
|
|
||
| ```text | ||
| chiptune level-clear jingle, bouncy two-bar fanfare, three-note rising motif F A C then a held tonic chord hit, square-wave lead with triangle bass and a noise-channel drum fill, cheerful arcade stage clear, ends cleanly, about 4 seconds | ||
| ``` | ||
|
|
||
| Generated and downloaded as WAV on October 15, 2026. Takes compared: this one and `4cc54a58-bf2a-44a4-8e24-ae2010b2de84`. This one is clearly in F major (Krumhansl fit 0.94; the other reads as C major) and scored higher on Meta's audiobox-aesthetics model (content enjoyment 6.38 against 6.08, production quality 7.59 against 7.12). | ||
|
|
||
| ## Delivery | ||
|
|
||
| Suno returned an 8.2 s phrase. It was raised 1.5 dB to −14 LUFS and cut to its closing phrase, the two bars before the final decay (3.415–8.154 s in the take), keeping the natural decay. A 4 ms fade-in and a 30 ms fade-out were applied, then the cut was encoded with `oggenc -q 6`, keeping Suno's embedded comment with the song ID. The `.import` leaves `loop` off. |
Binary file added
BIN
+98.6 KB
hoppys-adventure-arcade/Assets/Audio/Platformer/stinger_stage_clear.ogg
Binary file not shown.
19 changes: 19 additions & 0 deletions
19
hoppys-adventure-arcade/Assets/Audio/Platformer/stinger_stage_clear.ogg.import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| [remap] | ||
|
|
||
| importer="oggvorbisstr" | ||
| type="AudioStreamOggVorbis" | ||
| uid="uid://qpafxw1argjw" | ||
| path="res://.godot/imported/stinger_stage_clear.ogg-f6facadb7bc526d5171cf1e53fcea724.oggvorbisstr" | ||
|
|
||
| [deps] | ||
|
|
||
| source_file="res://Assets/Audio/Platformer/stinger_stage_clear.ogg" | ||
| dest_files=["res://.godot/imported/stinger_stage_clear.ogg-f6facadb7bc526d5171cf1e53fcea724.oggvorbisstr"] | ||
|
|
||
| [params] | ||
|
|
||
| loop=false | ||
| loop_offset=0 | ||
| bpm=0 | ||
| beat_count=0 | ||
| bar_beats=4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| extends SceneTree | ||
| ## Finishing any platformer level plays the stage-clear stinger once over the MERGE SUCCESSFUL | ||
| ## results: it keeps playing while the results pause the tree, the paused level music stays | ||
| ## silent under it, and a knockout never plays it. Run headless with | ||
| ## --script res://tests/platformer_stage_clear.gd. | ||
| const LEVELS := ["bay_area_blitz", "enchanted_repo", "orbital_ops"] | ||
| const STINGER := "res://Assets/Audio/Platformer/stinger_stage_clear.ogg" | ||
| var failures := 0 | ||
| var game: Node | ||
|
|
||
| func _initialize() -> void: | ||
| run.call_deferred() | ||
|
|
||
| func check(ok: bool, message: String) -> void: | ||
| print("PASS: " if ok else "FAIL: ", message) | ||
| if not ok: failures += 1 | ||
|
|
||
| func open_level(route: String) -> void: | ||
| change_scene_to_file("res://scenes/platformer/" + route + ".tscn") | ||
| await process_frame | ||
| await process_frame | ||
| game = current_scene | ||
| game._resume() | ||
| await create_timer(0.2).timeout | ||
|
|
||
| func run() -> void: | ||
| var stream := load(STINGER) as AudioStreamOggVorbis | ||
| check(stream != null and not stream.loop and stream.get_length() > 2.0 and stream.get_length() < 6.0, | ||
| "The stage-clear stinger is a short one-shot") | ||
| for route in LEVELS: | ||
| await open_level(route) | ||
| check(game.stage_clear.stream == stream and not game.stage_clear.playing, route + ": the stinger waits for the finish") | ||
| game._finish(true) | ||
| await create_timer(0.5, true, false, true).timeout | ||
| check(paused and game.stage_clear.playing and game.stage_clear.bus == &"Music", | ||
| route + ": MERGE SUCCESSFUL plays the stinger on the Music bus while the results pause the tree") | ||
| check(game.music.process_mode != Node.PROCESS_MODE_ALWAYS and game.music.can_process() == false, | ||
| route + ": the level music stays paused under the stinger") | ||
| var leave := game.find_children("*", "Button", true, false).filter(func(b: Button) -> bool: return b.text == "Return to Platformer Menu") | ||
| check(not leave.is_empty(), route + ": the results offer a way out") | ||
| if not leave.is_empty(): | ||
| (leave[0] as Button).pressed.emit() | ||
| check(not game.stage_clear.playing, route + ": leaving the results stops the stinger before the level music resumes") | ||
| await create_timer(0.6, true, false, true).timeout | ||
| paused = false | ||
| await open_level(route) | ||
| game.player.position.y = 900 | ||
| game.player._physics_process(0.0) | ||
| await create_timer(0.5, true, false, true).timeout | ||
| check(not game.stage_clear.playing, route + ": a knockout does not play the stage-clear stinger") | ||
| paused = false | ||
| print("PLATFORMER STAGE CLEAR: %s (%d failures)" % ["PASS" if failures == 0 else "FAIL", failures]) | ||
| change_scene_to_file("res://scenes/main_menu/main_menu.tscn") | ||
| await process_frame | ||
| await root.get_node("AudioService").settle() | ||
| quit(1 if failures else 0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| uid://cd5vqgnbgwu5e |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.