Repository navigation
Conversation
The plugin purges failed logins after 4 weeks while its settings have not been saved, but the settings page showed 0 (never) for that setting - so saving the settings for the first time switched purging off. The page now shows the plugin's default, and the hints of the block and failed login lists use the plugin's default too. Needs the plugin branch of the same name (codeling/bfstop), which adds deleteOld to the plugin's DefaultSettings that the test compares with this form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMMUpch4LGexEiXN8Nc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of B4 for the 2.0.0 release (codeling/bfstop#250). Merge together with the plugin PR on the branch of the same name in codeling/bfstop. The plugin's test compares its
DefaultSettingswith this form, so either one alone fails CI.Problem
While its settings are unsaved, the plugin purges failed logins after 4 weeks, but the settings page showed
0(never) for "Delete old entries". So the first save of the settings switched purging off, contrary to the changelog. The hints in the block list and failed login list also assumed 0 when the setting was unsaved.Change
deleteOlddefaults to 4 inadmin/forms/settings.xml.Bfstop::DefaultSettings['deleteOld'].Tests
testUnsavedSettingsAreWhatTheSettingsPageShows(in the plugin repo) now coversdeleteOld. It fails against this repo'smainand passes with this branch. The plugin's full suite passes locally with this branch, on Joomla 5.4.10 with MySQL 8.4 and PostgreSQL 16. Language and zip lint pass.Generated by Claude Code