Repository navigation
Conversation
A blocked IP address may reach com_users' reset and remind views, but the exemption looked at option and view only. Joomla runs the task of a request, not its view, so option=com_users&view=reset&task=user.login logged in from a blocked address - and the reset view hands out the form token for it. Without a task, only the two views pass now; with one, only the tasks of the recovery forms. Those forms post a task, usually without view=reset (index.php?task=reset.request), so before, the request which actually sends the reset mail could get blocked. The task is read the way Joomla's dispatcher does: in lower case, as controller.method (anything after a second dot ignored) or as a method with a "controller" parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMMUpch4LGexEiXN8Nc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1/4 for the 2.0.0 release (#250): this PR → #252 (B2) → #253 (B5) → #254 (B4, together with codeling/com_bfstop#25)
Problem
A blocked IP is allowed through to com_users' reset and remind views, so a locked-out user can still recover their account. The exemption (
isPasswordRecoveryRequest()) checked onlyoptionandview:taskof a request and ignores theviewwhen there is one. Sooption=com_users&view=reset&task=user.loginlogged in from a blocked address, as many times as the attacker liked. The reset page also hands out the form token the login needs. This is the same kind of hole as the unblock token bypass fixed earlier:isUnblockRequest()already requires an empty task.view=reset(index.php?task=reset.request,remind.remind,reset.confirm,reset.complete). So the request that actually sends the reset mail could get blocked, depending on SEF and menu items.Change
view=reset/view=remindpass.reset.request,reset.confirm,reset.complete,remind.remind,user.remind.requestedTask()reads the task the way Joomla'sComponentDispatcherdoes: lower case,controller.methodwith anything after a second dot ignored, or a bare method plus thecontrollerparameter. B2 (Login Only block mode: recognise a login however its task is spelled (B2) #252) uses it too.Tests
BlockedRequestTestadds:testPasswordRecoveryFormsCanBeSubmittedtestPasswordRecoveryViewIsNoPassForOtherTasks, which coversview=reset&task=user.login,task=login&controller=user,task=user.LOGINandtask[]=…testPasswordRecoveryStaysReachableBoth new tests fail on
mainand pass here. The full suite passes locally on Joomla 5.4.10 with MySQL 8.4 and with PostgreSQL 16. I couldn't test end to end in a browser (form token, SEF, menu items): that is H6 in #250.🤖 Generated with Claude Code
https://claude.ai/code/session_01AFJFMMUpch4LGexEiXN8Nc