Skip to content

test: teach the architecture catalog contract the two provenance shapes - #820

Merged
mrbobbytables merged 1 commit into
mainfrom
ci/fix-issue-import-provenance-contract
Sep 29, 2026
Merged

mrbobbytables merged 1 commit into
mainfrom
ci/fix-issue-import-provenance-contract

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

CI Fix

Scope claimed: tests/architecture-catalog-contract.test.mjs only — the catalog provenance/required-fields/doc-attribution tests. Disjoint from #812 (scripts/import-architecture-issue.mjs, mdx-escape), #810 (tests/import-architecture-issue.test.mjs), #818 (svg-active-content tests).

The architecture-submission workflow fails its own test:unit gate on every labelled submission: scripts/import-architecture-issue.mjs writes records sourced from the submission issue (sourceIssue + issue URL, no sourceCommit), but the contract required every record to carry a cncf/architecture-pinned sourceCommit. Proven by run https://github.com/cncf/endusers/actions/runs/36493874079 (issue #813) and reproduced locally.

This PR scopes the commit-pinning assertions to upstream-imported records and adds the mirrored contract for issue-submitted ones: sourceIssue is a positive issue number, sourceUrl is the submission issue URL, and the doc page cites the issue. No production code, script, or workflow changes; gates for the cncf/architecture path are unchanged.

Verified locally at 7772dcf:

Closes #819


Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88

scripts/import-architecture-issue.mjs writes records whose source is the
submission issue (sourceIssue + issue URL, no sourceCommit), while the
catalog contract required every record to carry a cncf/architecture-pinned
sourceCommit. The architecture-submission workflow therefore failed its own
test:unit gate on every labelled submission, before a PR could be created
(run 36493874079, issue #813).

Scope the commit-pinning assertions to upstream-imported records and add a
mirrored contract for issue-submitted ones: sourceIssue is a positive issue
number, sourceUrl is the submission issue, and the doc page cites it.

Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "ci-maintainer" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "ci-maintainer". If this is an outreach PR, a human must review it and remove the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci-maintainer] architecture-submission workflow can never pass: issue-imported records fail the catalog provenance contract

1 participant