test: teach the architecture catalog contract the two provenance shapes - #820
Merged
Merged
Conversation
scripts/import-architecture-issue.mjs writes records whose source is the submission issue (sourceIssue + issue URL, no sourceCommit), while the catalog contract required every record to carry a cncf/architecture-pinned sourceCommit. The architecture-submission workflow therefore failed its own test:unit gate on every labelled submission, before a PR could be created (run 36493874079, issue #813). Scope the commit-pinning assertions to upstream-imported records and add a mirrored contract for issue-submitted ones: sourceIssue is a positive issue number, sourceUrl is the submission issue, and the doc page cites it. Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "ci-maintainer" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 29, 2026
Merged
Closed
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Scope claimed:
tests/architecture-catalog-contract.test.mjsonly — the catalog provenance/required-fields/doc-attribution tests. Disjoint from #812 (scripts/import-architecture-issue.mjs, mdx-escape), #810 (tests/import-architecture-issue.test.mjs), #818 (svg-active-content tests).The architecture-submission workflow fails its own
test:unitgate on every labelled submission: scripts/import-architecture-issue.mjs writes records sourced from the submission issue (sourceIssue+ issue URL, nosourceCommit), but the contract required every record to carry a cncf/architecture-pinnedsourceCommit. Proven by run https://github.com/cncf/endusers/actions/runs/36493874079 (issue #813) and reproduced locally.This PR scopes the commit-pinning assertions to upstream-imported records and adds the mirrored contract for issue-submitted ones:
sourceIssueis a positive issue number,sourceUrlis the submission issue URL, and the doc page cites the issue. No production code, script, or workflow changes; gates for the cncf/architecture path are unchanged.Verified locally at 7772dcf:
npm run test:unit: red before, green afternpx prettier --checkclean; no other files touchedCloses #819
Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88