test: cover /resources, /community/governance and the platform-engineering TCG page end to end - #829
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…ering TCG page end to end No spec in tests/e2e loaded these three routes. The source side is pinned by tests/docs-contract.test.mjs and tests/root-docs-links.test.mjs, but those read Markdown off disk and cannot see whether the built site serves the route at all. /resources is the only doc whose body is hand-written JSX: it imports @docusaurus/Link and renders the two pillar cards that are the sole entry points to the case-study and radar-report tables. Closes #828 Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 29, 2026
Open
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
tests/e2e/docs-routes.spec.js, covering the three sidebar doc routes nospec in
tests/e2e/loaded:/resources,/community/governanceand/community/technical-community-groups/platform-engineering. The existingsuite reaches
/resources/case-studiesand/resources/radar-reportsbutnever the Resources landing page, and had never requested either community doc.
tests/docs-contract.test.mjsandtests/root-docs-links.test.mjspin thesource files, and unit coverage for the components these pages render is
already 100% line and region — but all of that reads Markdown off disk. None of
it can see whether the built site serves the route: a page can stay reachable
from the navbar while rendering an empty shell.
What the five cases assert:
/resourcesanswers < 400, is not the "Page Not Found" page, renders its<article>and itsnav.menusidebar, and each pillar link ("Case Studies","Radar Reports") navigates to the route it names and renders content there.
This page is the only doc on the site whose body is hand-written JSX — it
imports
@docusaurus/Linkfor the two pillar cards that are the sole entrypoints to the case-study and radar-report tables, so a
<Link to>that stopsresolving under the deployed
baseUrlbreaks both with nothing to catch it./community/governancerenders its article and sidebar and still shows the"Source and license" admonition plus the upstream
cncf/tablink, withoutwhich the reproduced text may not be republished.
/community/technical-community-groups/platform-engineeringrenders itsheading and sidebar, and its relative
../governance.mdlink resolves to/community/governanceat runtime instead of being emitted as a source path.Tests only; no production code is touched. Verified locally against a fresh
npm run build:production(E2E_PORT=3137 npx playwright test): 118 tests,all green — the 113 pre-existing plus these 5.
npm run test:unit:coverage:checkstill passes (the new file is a
.spec.jsundertests/e2e/, sonode --testdoes not pick it up).
Scope
Claims
tests/e2e/docs-routes.spec.jsand the three routes named above.Deliberately disjoint from the open hold-gated PRs, none of which touch
tests/e2e/: #810 and #812 (scripts/import-architecture-issue.mjs), #818(
scripts/lib/svg-active-content.mjs), #820(
tests/architecture-catalog-contract.test.mjs), #825(
tests/collect-case-studies.test.mjs,tests/import-architectures.test.mjs,tests/validate-architecture-assets.test.mjs) and #827 (static/assetsecurity).
Related Issue
Closes #828
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88