fix: Bound plugin downloads with transport timeouts - #684
Draft
erezrokah wants to merge 2 commits into
Draft
Conversation
http.DefaultClient has no timeout of any kind, so a plugin asset server that accepts the connection and then goes silent holds the attempt until a middlebox tears the connection down minutes later. Route both asset requests through a dedicated client with dial, TLS handshake, response-header and per-read idle deadlines. Timeouts produced by that client are re-labelled as retryable, since they otherwise reach the classifier indistinguishable from the caller's own deadline.
disq
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin asset requests now go through a dedicated HTTP client with dial, TLS handshake, response-header and per-read idle deadlines instead of the timeout-free
http.DefaultClient, so a server that goes silent fails in seconds and retries rather than hanging until a middlebox tears the connection down.