fix: Abort stalled plugin downloads quickly and retry them - #683
Closed
disq wants to merge 1 commit into
Closed
Conversation
erezrokah
approved these changes
Sep 1, 2026
erezrokah
left a comment
erezrokah
left a comment
Member
There was a problem hiding this comment.
Maybe also handle getURLLocation?
Member
|
Cleaner to use |
Member
Author
|
Superseded by #684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A download whose server goes silent (headers or mid-body) previously hung until a middlebox killed the connection ~125s later; a per-attempt watchdog now cancels the attempt after 30s without progress and classifies the failure as retryable, so a stall costs seconds instead of minutes while a caller's own cancellation stays terminal.