Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/bump-break-check-incomplete-ai-reviews.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 1 addition & 1 deletion .github/workflows/api-changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ env:
# The tool was renamed snapi -> break-check (package @clerk/break-check, binary
# break-check, repo clerk/break-check). Pinned to a pkg.pr.new build of a
# specific commit on main.
BREAK_CHECK_PACKAGE: https://pkg.pr.new/clerk/break-check/@clerk/break-check@98cb22591751a1628e4e260064ddffa5647d6de5
BREAK_CHECK_PACKAGE: https://pkg.pr.new/clerk/break-check/@clerk/break-check@aae2962cd76869d26dfc06e438c4af825827078b
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the break-check commit exists and the package URL is accessible

# Check if the commit exists in the clerk/break-check repository
echo "Checking if commit exists in clerk/break-check..."
gh api repos/clerk/break-check/commits/aae2962cd76869d26dfc06e438c4af825827078b \
  --jq '.sha, .commit.message' || echo "ERROR: Commit not found"

# Verify the pkg.pr.new URL returns a valid response
echo -e "\nChecking if package URL is accessible..."
curl -I -s "https://pkg.pr.new/clerk/break-check/@clerk/break-check@aae2962cd76869d26dfc06e438c4af825827078b" | head -n 1

Repository: clerk/javascript

Length of output: 350


Fix pinned commit hash: it doesn’t exist in clerk/break-check (while the pkg URL currently resolves)

In .github/workflows/api-changes.yml (line 49), GitHub API lookup for aae2962cd76869d26dfc06e438c4af825827078b in clerk/break-check returns 404 (commit not found). Meanwhile, https://pkg.pr.new/clerk/break-check/@clerk/break-check@aae2962cd76869d26dfc06e438c4af825827078b responds with HTTP 200. Reconfirm the correct repo/ref for the pinned hash (or update the pin to a commit that actually exists in the target repository).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/api-changes.yml at line 49, The BREAK_CHECK_PACKAGE pin
value is set to a commit hash that GitHub reports as missing; open
.github/workflows/api-changes.yml and update the BREAK_CHECK_PACKAGE entry:
verify the correct repository/ref for the hash (or find the actual commit SHA in
the clerk/break-check repo) and replace the current value
(aae2962cd76869d26dfc06e438c4af825827078b) with a commit SHA that exists in
clerk/break-check (or change the ref to a tag/branch that resolves), ensuring
the pkg.pr.new URL and GitHub API both resolve to the same valid ref.

BREAK_CHECK_FILTERS: >-
--filter=@clerk/astro
--filter=@clerk/backend
Expand Down
Loading