ci(repo): bump break-check to #59#8732
Conversation
…iew surfacing)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 8e94212 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/api-changes.yml:
- Line 49: The BREAK_CHECK_PACKAGE pin value is set to a commit hash that GitHub
reports as missing; open .github/workflows/api-changes.yml and update the
BREAK_CHECK_PACKAGE entry: verify the correct repository/ref for the hash (or
find the actual commit SHA in the clerk/break-check repo) and replace the
current value (aae2962cd76869d26dfc06e438c4af825827078b) with a commit SHA that
exists in clerk/break-check (or change the ref to a tag/branch that resolves),
ensuring the pkg.pr.new URL and GitHub API both resolve to the same valid ref.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b0b10afa-9ce8-427f-95aa-d24a75019287
📒 Files selected for processing (2)
.changeset/bump-break-check-incomplete-ai-reviews.md.github/workflows/api-changes.yml
| # break-check, repo clerk/break-check). Pinned to a pkg.pr.new build of a | ||
| # specific commit on main. | ||
| BREAK_CHECK_PACKAGE: https://pkg.pr.new/clerk/break-check/@clerk/break-check@98cb22591751a1628e4e260064ddffa5647d6de5 | ||
| BREAK_CHECK_PACKAGE: https://pkg.pr.new/clerk/break-check/@clerk/break-check@aae2962cd76869d26dfc06e438c4af825827078b |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the break-check commit exists and the package URL is accessible
# Check if the commit exists in the clerk/break-check repository
echo "Checking if commit exists in clerk/break-check..."
gh api repos/clerk/break-check/commits/aae2962cd76869d26dfc06e438c4af825827078b \
--jq '.sha, .commit.message' || echo "ERROR: Commit not found"
# Verify the pkg.pr.new URL returns a valid response
echo -e "\nChecking if package URL is accessible..."
curl -I -s "https://pkg.pr.new/clerk/break-check/@clerk/break-check@aae2962cd76869d26dfc06e438c4af825827078b" | head -n 1Repository: clerk/javascript
Length of output: 350
Fix pinned commit hash: it doesn’t exist in clerk/break-check (while the pkg URL currently resolves)
In .github/workflows/api-changes.yml (line 49), GitHub API lookup for aae2962cd76869d26dfc06e438c4af825827078b in clerk/break-check returns 404 (commit not found). Meanwhile, https://pkg.pr.new/clerk/break-check/@clerk/break-check@aae2962cd76869d26dfc06e438c4af825827078b responds with HTTP 200. Reconfirm the correct repo/ref for the pinned hash (or update the pin to a commit that actually exists in the target repository).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/api-changes.yml at line 49, The BREAK_CHECK_PACKAGE pin
value is set to a commit hash that GitHub reports as missing; open
.github/workflows/api-changes.yml and update the BREAK_CHECK_PACKAGE entry:
verify the correct repository/ref for the hash (or find the actual commit SHA in
the clerk/break-check repo) and replace the current value
(aae2962cd76869d26dfc06e438c4af825827078b) with a commit SHA that exists in
clerk/break-check (or change the ref to a tag/branch that resolves), ensuring
the pkg.pr.new URL and GitHub API both resolve to the same valid ref.
|
Break Check: no API changes detected across the tracked packages. Last ran on |
2 participants
Bumps the pinned
break-checkbuild from #51 to #59. This is just theBREAK_CHECK_PACKAGEURL; the snapshot/detect invocation is unchanged and stays backwards-compatible.Worth picking up because the intervening commits fix two failure modes we actually hit. #57 fixes the AI reviewer confirming backwards-compatible changes as breaking (the false positives on #8700), and #59 fixes AI reviews that failed silently on oversized types and still claimed full coverage, which is what forced the spurious 5.0.0 on #8177. #59 also reorders the report breaking-first so the breaking list survives comment truncation, and #57 adds an
acknowledgedChangesallowlist we can adopt later if we want to green a verified-safe break by name.