Repository navigation
fix: keep task modal open when save validation fails (#2421) - #2422
Merged
callumalpass merged 3 commits intoOct 26, 2026
Merged
Conversation
The Save button closed the modal as soon as handleSave() resolved, even when it returned early on validation (e.g. empty title), discarding the form. handleSave() now returns false on validation failure and the save action skips the close callback in that case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/releases/unreleased.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2421.
The Save button closed the task modal as soon as
handleSave()resolved, even when it returned early on validation (for example an empty title). The notice asked the user to fill in a field, but the form had already been discarded.Changes
runTaskModalSaveAction()callsonSaved()(which closes the modal) only whenonSave()does not resolve tofalse.TaskCreationModal.handleSave()andTaskEditModal.handleSave()returnfalsewhen the title check fails. The abstract signature becomesPromise<boolean | void>, so other callers are unaffected.taskModalActionButtons.test.ts.Testing
npx jest tests/unit/modals: passingtsc -noEmit --skipLibCheck: cleanThis is also a prerequisite for #2420 (required modal fields), which I'll send as a separate PR.
🤖 Generated with Claude Code