Repository navigation
Conversation
The Save button closed the modal as soon as handleSave() resolved, even when it returned early on validation (e.g. empty title), discarding the form. handleSave() now returns false on validation failure and the save action skips the close callback in that case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andriyor
marked this pull request as ready for review
October 24, 2026 12:43
ModalFieldConfig.required was declared "future use" and never read. Modal Fields settings now show a Required switch on every field except Title (always required). The create and edit modals refuse to save while a required field shown in that modal is empty and list the empty fields in a notice. Hidden or disabled fields are not enforced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andriyor
force-pushed
the
feat/required-modal-fields
branch
from
October 24, 2026 12:46
62c7da3 to
f4bccac
Compare
andriyor
marked this pull request as draft
October 24, 2026 12:46
andriyor
marked this pull request as ready for review
October 24, 2026 12:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2420.
Depends on #2422. This branch currently includes its commit (
fix: keep task modal open when save validation fails); without it the modal closes after the "required" notice and the form is lost. I'll rebase once #2422 is merged.What it does
ModalFieldConfig.requiredexisted but was marked "future use" and never read.Fill in required fields: Contexts, Projects).falseboolean user field is not treated as empty).docs/settings/modal-fields.md.Due, scheduled, priority and status live in the action bar rather than in Modal Fields, so they can't be marked required with this change.
Changes
src/modals/taskModalFieldConfig.ts:getMissingRequiredModalFields()src/modals/TaskModal.ts:validateRequiredFields()andisModalFieldEmpty(), called fromhandleSave()in the create and edit modalssrc/settings/components/FieldManagerComponent.ts: the switchsettings.modalFields.manager.requiredandmodals.task.requiredFieldsMissingin all locales; manifest and state updated withnpm run i18n:syncdocs/settings/modal-fields.mdtests/unit/modals/taskModalFieldConfig.test.ts(helper) and aRequired modal fields (#2420)block intests/unit/modals/TaskCreationModal.test.ts(save is blocked while a required core or user field is empty, saves once filled, hidden fields are not enforced)Testing
npm run build,tsc, fullnpx jest(5475 passed),npm run i18n:verify🤖 Generated with Claude Code