feat: add typed leading and trailing slots to List.Item - #5042
Draft
adam-sajko wants to merge 11 commits into
Draft
feat: add typed leading and trailing slots to List.Item#5042adam-sajko wants to merge 11 commits into
adam-sajko wants to merge 11 commits into
Conversation
adam-sajko
force-pushed
the
feat/list-typed-slots
branch
2 times, most recently
from
August 24, 2026 09:48
96e1127 to
aba3b2a
Compare
This was referenced Aug 25, 2026
adam-sajko
force-pushed
the
feat/list-typed-slots
branch
6 times, most recently
from
September 1, 2026 14:26
a5c56de to
e155220
Compare
adam-sajko
force-pushed
the
feat/list-typed-slots
branch
from
September 3, 2026 11:09
e155220 to
c692ed1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#4930 wants explicit slots instead of layout tied to render props. Right now
leftandrighthand the caller astyleobject and acolorand trust them to apply both, soList.Itemdoes not really own its own layout.leadingandtrailingtake a node and win overleftandrightwhen both are passed.List.Itemwraps the node itself and puts the color on a small context, soList.Iconpicks it up without the caller doing anything. That is the newListItemContextand the one line inListIcon.Related issue
Related to #4930 and #4976
Draft, stacked on #5041 and #5057. Only the typed slots commit is this PR's change, the rest is the stack until those merge so github will show those commits until they land.
Test plan
Unit tests for the new slots side by side with the old
leftandright, both paths should still work.