Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on af69e16. The verdict and the full list are in the summary comment.
|
Both findings are fixed in 45bb635. The MCP audit fixtures now include The MCP test file is included in the root typechecked project through The size exemption now requires a direct bar parent. Scroll containers, content containers, and other controls stop the exemption. The four new negative cases failed at af69e16. All 139 focused tests and typecheck pass at 45bb635. The affected gate passed with The review thread is resolved. Hosted CI must validate the pushed head. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 45bb635. The verdict and the full list are in the summary comment.
|
Thanks for this. This review covers 45bb635; b61e3a1 landed while it ran and gets its own delta review. At 45bb635 the audit still reports bar-item small-targets and scroll-under-bar covered-controls on one iOS shape, so it needs one more change. All 21 checks pass at this commit. The persistent-chrome list in snapshot-audit.ts:310 copies the first five bar fragments from snapshot-occlusion.ts:16-21. It reads only Could one exported predicate from The open thread on the type-only parent check still stands and is covered above. Its fixture citation is off (the iOS 27 toolbar node has type Not blocking, and you can take or leave these: the This change is not device-facing, so no live run is needed. There are no conflicts. Before merge, route the bar-chrome check through the occlusion owner and add the role-shaped test. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the update. At b61e3a1 the parent check now goes through The scroll-chrome exclusion still reads the display string Could the simpler route be a typed Not blocking, take or leave: the The two earlier inline threads on the type-only parent check (r4604751593) and the ancestor walk (r4604548741) look fixed at this commit, so you can resolve them. Before merge, the covered-control exclusion needs to go through the typed bar flag with the producer-driven test. |
|
Thanks. The covered-control exclusion now reads a typed bar fact. Head is 12e6d1b. What changed:
Evidence:
Gate: The inline threads r4604751593 and r4604548741 were already resolved. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 12e6d1b. The verdict and the full list are in the summary comment.
|
One problem from the earlier review (#4652 (comment)) is still open at 12e6d1b. The other earlier points look fixed in this update. All 18 checks pass at this commit, and there are no conflicts. An unnamed persistent bar with a generic type now publishes a cover in snapshot-occlusion.ts:164, but its kind stays No device run is needed for this change. The open inline thread on this kind (#4652 (comment)) still stands. Two other threads no longer apply and can be resolved: the ancestor walk now uses a visited set (#4652 (comment)), and the parent check goes through Before merge, give an unnamed persistent-bar cover a recognizable kind so the refusal never says "the other ... Dismiss or close that element". |
|
Thanks. The unnamed persistent-bar cover is fixed in 9c3d971.
|
This comment has been minimized.
This comment has been minimized.
|
Thanks for the update. At 9c3d971 the earlier persistent-bar cover finding is fixed: an unnamed Other+UITabBar cover now publishes kind tab-bar, and the persistent-bar hint no longer suggests dismiss. One defect remains in the same hint. The persistentBar branch in interaction-error.ts:94 tells every target to scroll clear of its cover. The cover marker only identifies the cover. It carries no evidence that the target can scroll. The new click regression has a fixed Save draft button under the bar, with a sibling tab bar and no scroll container. The audit fixture keeps that fixed control under the bar too (snapshot-audit.test.ts:377-420). An agent that gets a click refusal for a fixed control is sent to a scroll that cannot move it, and it may retry in a loop. Please make the scroll suggestion conditional on scrollable content. For a fixed target, point to a different visible target or to snapshot inspection. Update the hint assertion and the snapshot docs to match. Simplicity question: could snapshot-audit.ts keep the persistent-bar suppression rule and use The open inline thread on the tab-bar kind is fixed at this head, so you can resolve it: #4652 (comment) CI is green: 18 checks, none failing at 9c3d971. There are no conflicts. Which live capture (XCTest, Appium, macOS AX) emits an unlabeled Other with role UITabBar is not confirmed, so the fixture shape is synthetic. No device run is needed. Before merge, the hint needs the fix above. |
|
Thanks. The persistent-bar hint is fixed in 0c64c70.
Evidence:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 0c64c70. The verdict and the full list are in the summary comment.
This comment has been minimized.
This comment has been minimized.
|
The hint finding from the earlier review (9c3d971) is fixed at 8a867b5: covered-control guidance in snapshot-audit.ts no longer tells the reader to dismiss persistent bar chrome, and snapshot-audit.test.ts pins it. One docs mismatch remains.
Could packages/contracts/src/snapshot-text.ts own the full bar identity, including bottom navigation, with packages/capture-kit/src/snapshot-occlusion.ts selecting the three existing kinds for viewport exemptions? Capture would still own the occlusion facts, and audit and interaction would still consume those facts without parsing platform role strings. The open inline thread on covered-control guidance (#4652 (comment)) no longer applies at 8a867b5, so the author can resolve it. All 18 checks pass at 8a867b5, and there are no conflicts. No device run is needed for this diagnostic text. After the help text matches the hint and the bar-identity question above is answered (a smaller design, or why it was rejected), nothing else stands between this PR and merge. |
|
Both review items are addressed at a83226f. Item 1 (docs): `agent-device help manual-qa` no longer tells the reader to dismiss or scroll clear any cover for `target_covered`. The recovery now matches the production hint in `packages/selectors/src/interaction-error.ts`: dismiss only dismissible covers (sheet, dialog, alert); under a persistent bar (tab bar, toolbar, navigation bar, bottom navigation) use a different visible target or inspect with snapshot/screenshot, scrolling past the bar only when `coveredBy.targetInScrollableContent` is true. The old wording had no other copies in `src/`, `website/docs`, or `skills/`; `website/docs/docs/snapshots.md` already matched the hint. `cli-help-workflows.test.ts` now pins the new wording and the absence of the old. Item 2 (bar identity): `packages/contracts/src/snapshot-text.ts` now owns the full bar identity; `SNAPSHOT_BAR_KINDS` includes `bottomnavigation` mapped to `bottom-navigation`, so `snapshotBarKind`/`isSnapshotBarNode` cover it. `packages/capture-kit/src/snapshot-occlusion.ts` dropped its separate `BOTTOM_NAVIGATION_KIND_FRAGMENTS` match and now selects the three existing kinds (`tab-bar`, `toolbar`, `navigation-bar`) for the viewport-chrome exemptions via a local `VIEWPORT_CHROME_BAR_KINDS` set. An Android `BottomNavigationView` is therefore still excluded from the viewport exemption: it keeps covering the content behind it while publishing `persistentBar: true`. Capture still owns the occlusion facts, and audit and interaction consume those facts without parsing platform role strings. Test evidence: focused vitest on the touched files passes (192 tests, including 6 new pins for bar identity in `snapshot-text.test.ts` and for a full-viewport BottomNavigationView still covering in `snapshot-occlusion.test.ts`). The broader suites for `packages/capture-kit`, `packages/contracts`, `packages/selectors`, and `src/commands/schema` pass (2453 tests across 279 files). `pnpm format` is clean. Gate: `pnpm build` succeeded and `pnpm check:affected --run` reported all runnable checks passed (exactCommit=true). The branch was pushed as a83226f. Review thread r4616012731 was already resolved; confirmed isResolved=true via the GraphQL API, so no resolve action was needed. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on a83226f. The verdict and the full list are in the summary comment.
|
Thanks for the update. At 3fa25fb the earlier covered-control guidance concern is fixed, and bar identity now lives in In snapshot-occlusion.ts:228, Could Of the open threads from other reviewers, this one on the bottom navigation role no longer applies. No checks had reported on 3fa25fb yet, and none are failing. All 18 checks passed at 8a867b5. No conflicts are known. Before merge, the scroll-viewport case needs the fix above and the checks must report green at 3fa25fb. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 3fa25fb. The verdict and the full list are in the summary comment.
…hint; own full bar identity in contracts - cli-help-workflows.ts: the manual-qa recovery for target_covered no longer tells the reader to dismiss or scroll clear any cover. It now points at the production hint's recovery: dismiss only dismissible covers (sheet, dialog, alert); under a persistent bar use a different visible target or inspect with snapshot/screenshot, scrolling past the bar only when coveredBy.targetInScrollableContent is true. cli-help-workflows.test.ts pins the new wording and the absence of the old. - contracts/snapshot-text.ts: SNAPSHOT_BAR_KINDS gains bottomnavigation -> bottom-navigation, so snapshotBarKind/isSnapshotBarNode own the full bar identity. capture-kit/snapshot-occlusion.ts drops its separate BOTTOM_NAVIGATION_KIND_FRAGMENTS match and selects the three existing kinds (tab-bar, toolbar, navigation-bar) for the viewport-chrome exemptions via a local VIEWPORT_CHROME_BAR_KINDS set, so an Android BottomNavigationView still covers content instead of being exempted. New tests pin the bar identity in contracts and the bottom-navigation occlusion behavior in capture-kit. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
At 3fa25fb this branch now conflicts with main. Please rebase onto main and push; the open scroll-viewport finding from the last review still stands. |
3fa25fb to
7d61884
Compare
|
Rebased on main and resolved the overlapping recovery help entries. The updated keyboard guidance and covered-target guidance are both present.
The affected gate passed at |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 7d61884. The verdict and the full list are in the summary comment.
|
Addressed both Sentinel findings in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
At 95758cb, the earlier conflict is fixed, but the clearance decision and its coverage still need changes. The other checks pass, and the remaining one is a review check. No conflicts are known. Before merge, correct the clearance decision and regression coverage, align the help, record device evidence. Could the scan use the measured viewport from state assembly, with valid root geometry as fallback? A rootless Android helper capture can retain a scroller beyond the display, so the off-screen segment can suppress a covered finding and suggest an unreachable scroll. Pin this path through state assembly. The earlier synthetic helper XML reproduced the geometry; its occurrence on a live device remains unverified. Scan Require capture evidence that movement can take the center toward an exposed point on each axis and direction. An explicit axis alone can suppress a finding when content fits or the scroller is at its forward limit, and Android currently drops horizontal action hints. Keep the marker absent without evidence, and replace the directionless positive with a movable case plus fit and end-of-range cases. Decision Qualify the exclusion in audit help with supported scroll clearance, following the shared producer's rule. Controls whose whole usable path is covered remain in the audit, contrary to the current description. Help Say findings show their role and include the captured label when available. Missing-name findings and controls named by descendants or placeholders may have no label of their own. Reference Please provide same-head Android helper and native iOS commands and output for wholly blocked and genuinely revealable horizontal scrollers through the daemon. On Android, show androidSnapshot.backend=android-helper and the matching helperVersion in snapshot -i --json. On both platforms, show audit --json and a fresh-ref covered press: the blocked case must show covered-control, target_covered, no scrollCanReveal and alternate-target or inspection advice; the revealable case must show scrollCanReveal, no covered finding and a scroll hint, followed by a scroll, refreshed ref and successful press. On iOS also show an unnamed native direct bar item retaining missing-name and a small custom-bar child retaining its size finding. Fixtures alone do not establish what live capture publishes. Decision Drive the clipping regression through buildSnapshotState with a measured 400×800 viewport, rootless nodes and movement evidence toward an off-screen exposed segment. Verify that removing the measured clip changes the marker or finding. The current fixture passes without the clip because it has no hidden-content evidence. Test Use available travel bounds to prove an exposed point, or retain the finding and use alternate-target recovery when the bound is insufficient. A center at y=860 behind a bar at y=791..874 cannot clear it with only 10pt of upward travel, although the current path extends to the viewport edge. Decision Align the snapshot explanation with the corrected capture-evidence contract. Until then, describe the geometry and class-based inference: rootless Android ignores its measured viewport and an explicit class axis can publish the marker without directional evidence. Snapshot docs Describe the size exemption as applying to direct items of recognized native iOS bars in both the command reference and audit help. Custom bar children remain subject to the size check. Reference Could one occlusion decision and the existing marker use normalized movement evidence from capture and the measured viewport from state assembly, intersect the supported reachable path with that viewport once, and check it against the cover? Extend the existing projection with supported axis, direction and sufficient travel evidence where available, reuse the existing rect and scroll contracts, remove class-name reachability branches and assumed edge travel, and retain the finding when clearance cannot be established. One lower-priority thread still applies. These threads can be resolved: bottom navigation classification is fixed at head (#4652 (comment)); exact native parent identity and the custom-bar regression are present (#4652 (comment)); canonical bottom-navigation kind is published for concrete Android classes (#4652 (comment)). Not blocking: the interaction error comment can be removed or updated to describe the guarantee after the shared decision enforces it; take or leave this change. Please also include before-and-after fixture output for the named Safari History and nested-scroll Row findings, and a live record at this head of OS-generated iOS labels. This is the fourth round on the scroll-clearance decision. If it does not converge in the next push, please consider splitting it out: land the finding names and the persistent-bar noise removal here, and move scroll clearance to its own PR with the live evidence. |
|
I split scroll clearance out of this PR in The remaining clearance work needs capture-owned travel bounds. The Android helper’s scroll actions and the iOS direction hints do not supply the distance. A follow-up needs a rootless 400×800 state-assembly test that fails without clipping, fit and edge cases, a short-travel case, and live blocked and revealable paths on Android and iOS. I reran the ref fixtures with the production presenter and audit code. Full capture reports Safari On iOS 26.2, T3 captured a native toolbar with a 30×30 pt unnamed direct item and a system Add item whose label was supplied by UIKit. It also captured a named 24×24 pt child of The affected gate passed on |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on ea1bbc8. The verdict and the full list are in the summary comment.
|
This review covers ea1bbc8. The newer head 6d872cc requires exact persistent-bar identity, which answers the open custom-cover question, and it will get its own delta review. The items below do not depend on it. The earlier clearance policy is removed at ea1bbc8, and the changed assertions distinguish it from the retained behavior. The audit promises and live evidence still need work before merge. The help says UIKit sheet grabbers are skipped, but the independent covered pass can still report a grabber covered by a later overlay. Can the system ownership rule also apply to covered findings and their duplicate-parent check, or can the help and reference limit the promise to size and name checks? Audit The reference says captured labels are included when available, but a missing-name finding omits an Android resource identifier even when it was captured as the only label. Please state that missing-name findings omit labels rejected by the accessible-name check and can display the captured identifier. Reference The supplied iOS capture used a different client and daemon pair followed by offline replay, and there is no daemon output at this head for either platform. Please record same-head native iOS and Android-helper runs through a protocol-compatible daemon, including commands, device, SHA and outputs. For each platform, show snapshot -i --json identifying the persistent cover, audit --json reporting covered-control for a covered control in a scroll view, and a fresh-ref press returning target_covered with the canonical cover, persistentBar: true and alternate-target or inspection guidance. The payload must omit scrollCanReveal and the hint must omit scroll and dismiss advice. On Android, show androidSnapshot.backend=android-helper and helperVersion matching package.json. On iOS, include the native direct item and custom-bar child, and show the daemon audit reporting missing-name without small-target for the unnamed native item, small-target for the custom child, and no missing-name for the captured Add label. The clearance matrix and clipping mutation belong with the deferred clearance implementation. Recovery The custom cover persistence thread still applies; no lower-priority threads remain applicable. The bottom navigation thread is fixed by kind ordering and the viewport exemption. The iOS size thread is fixed by exact native identity and custom-child coverage. The clearance thread is fixed by removing the clearance policy. The Android kind thread is fixed by canonicalizing the bottom-navigation kind. All 18 checks pass at ea1bbc8. There are no known conflicts. Align the grabber and label promises with the audit paths and attach the same-head daemon evidence before merge. |
This comment has been minimized.
This comment has been minimized.
|
The affected gate passed with |
This comment has been minimized.
This comment has been minimized.
|
At b584745, the HomeToolbarView name-fragment issue is fixed, but source identity and live device evidence still need work. All 18 hosted checks pass. There are no conflicts. Could persistence require source-qualified native type or role evidence, or an explicit backend fact, on both cover construction routes? A labelled DOM toolbar can currently receive persistentBar from hit-test evidence, and a custom Android class can collide after its namespace is stripped. This can mark an app overlay as persistent and remove dismiss or scroll recovery for a covered ref. Please retain names and geometry for generic covers and add a labelled ARIA toolbar regression alongside the native and HomeToolbarView cases. https://github.com/callstack/agent-device/blob/b584745/packages/contracts/src/snapshot-text.ts#L35 Please attach raw output with the command, device and build SHA from the branch-built CLI ( Could the existing snapshot producer identity qualify persistence at cover construction, with viewport geometry kept local, generic named covers retained, and audit using verified direct-parent identity for the size exemption? What would have to change first to narrow the cover-evidence input so a generic role cannot authorize persistence while retaining the two marker consumers? The HomeToolbarView thread can be resolved: exact matching and the dismissal regression address its reported case. Before merge, please qualify persistence on both cover routes and attach the same-head iOS and Android-helper evidence. |
|
The shared cover descriptor receives a verified bar kind separately from the observed type, role, label and rect. The backend hit-test and Android replacement-surface routes cannot pass a verified kind through their generic evidence. A future backend that can attest to a persistent cover would need a separate typed fact from that backend. Snapshot output and refusal recovery continue to read the one published marker. The ARIA regression preserves the labelled cover and its rect without marking it persistent. Android snapshot assembly distinguishes the Material BottomNavigationView class from a custom class with the same leaf name. The affected gate passed with The requested same-head live runs remain open. The local T3 device host still requires client 0.21.36, which supports RPC protocol 2. The branch daemon requires protocol 3. The earlier iOS capture and offline audit replay are separate evidence. |
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
At c70a9dd, persistence now requires source-qualified native evidence, and the HomeToolbarView fix holds, but the native capture behavior still needs live evidence before merge. No conflicts are known. All 18 checks pass. Could you attach raw output from c70a9dd using the branch-built node bin/agent-device.mjs and its own daemon on native iOS and Android-helper? The audit and covered-refusal route now depends on the capture producer and native type or class values, while the cited iOS capture and offline replay precede this change. Record the build SHA, device, commands, and output. On each device, show snapshot -i --json identifying a recognized persistent cover over a scroll-view control, audit --json reporting covered-control, and a fresh snapshot followed by a press of that covered ref. The refusal must show target_covered, the canonical coveredBy.kind and persistentBar: true, omit scrollCanReveal, and offer visible-target or inspection recovery without scroll or dismissal advice. The Android output must show androidSnapshot.backend=android-helper and a helperVersion matching package.json. On iOS, also show that an unnamed native direct item gets missing-name without small-target, a custom-bar child gets small-target, and the captured generated Add label avoids missing-name. This will establish that native capture preserves the class and producer through daemon assembly, audit, and a fresh-ref press. Capture route Not blocking: The producer rows could own the native bar naming capability, with the classifier and iOS eligibility derived from that capability and the existing channel; take or leave this suggestion. Could SnapshotProducerFacts be extended under ADR 0038 so the contracts matcher and iOS exemption share that match, removing repeated producer checks while leaving cover publication and viewport geometry with their current owners? No new transport field or ADR appears necessary. |
Summary
Audit findings show their role and include the captured label or identifier when available. Guidance appears once per finding kind. Size and name checks skip UIKit sheet grabbers. Direct items of recognized native iOS bars keep name checks and skip size checks. Custom bar children and nested app content retain size checks.
Audit reports covered controls inside scroll views. Recognized persistent bars require native source evidence and get visible-target or inspection guidance. ARIA and custom toolbar overlays keep generic cover recovery. Scroll clearance is separate work that requires capture-owned travel bounds and live Android and iOS cases.
29 files.
agent-device auditcan report@e20~s815872 small-target button "Save Lemon Herb Rice" 22×22pt, below 44×44pt.agent-device audit --jsonadds optionallabelandidentifierplus top-levelguidance.Audit still uses full capture. In fixture output, Safari History at 370×28 pt and nested-scroll Row high at 370×40 pt disappear in the interactive projection.
Validation
pnpm check:affected --run --head c70a9dd57c0a485d76a591360be06b8cfa625a55passed withexactCommit=true. GitHub owns hosted checks.A live iOS 26.2 capture showed an OS-generated Add label. Offline replay through ea1bbc8 retained the unnamed native item’s missing-name finding and the custom-bar child’s small-target finding. Exact-head live iOS and Android-helper evidence remains pending. The T3 client supports RPC protocol 2 and the branch daemon requires 3.