Repository navigation
docs(help): add accessibility review help topic - #4651
Conversation
Size Report
Startup median (7 runs, lower is better):
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 3 new findings on b089cbc. The verdict and the full list are in the summary comment.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 922e495. The verdict and the full list are in the summary comment.
This comment has been minimized.
This comment has been minimized.
|
Thanks for the topic. At 3046e9d I found one problem that should be fixed before merge. All 21 checks pass, and there are no conflicts. Step 2 of the loop runs Not blocking: you can take or leave these. On a physical iPhone The four earlier inline threads are fixed at this head and can be resolved: the relaunch-order regex (thread), the SKILL.md routing to help accessibility (thread), the recorded and restored size and mode (thread), and the matcher comment now agreeing with the two-audit test (thread). Before merge, the step 3 wording needs to change, together with the identical sentence in help dogfood. Then please refresh the validation section of the PR body. |
This comment has been minimized.
This comment has been minimized.
|
Fixed at df32cc7.
|
This comment has been minimized.
This comment has been minimized.
|
Thanks for the update. Both earlier inline threads are fixed at df32cc7, but one problem from the earlier review remains: the help text promises element names that Step 3 in cli-help-workflows.ts:215 tells the agent to record each finding with its element name and to match the finding to the snapshot by element name. The dogfood platform checks (line 263) say the same. On this head, Not blocking: the new line at cli-help-workflows.ts:233 says The two inline threads at #4651 (comment) (text-size ordering before CI is still running on this head and nothing has failed so far. The diff is help strings, tests, a bench script, SKILL.md and a website doc, with no runtime code. The help-conformance bench and |
|
Fixed at 6a4ec0e.
|
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
This PR is ready at 6a4ec0e. The earlier findings from #4651 (comment) are fixed: step 3 and the dogfood Platform checks no longer match by name, and Not blocking, and you can take or leave it: step 2 runs plain The four inline threads from other reviewers are resolved and none are still open. No device run is needed for help text. The claim that audit rects and snapshot -i rects are comparable rests on contracts/audit.ts:20 and the snapshot help. The Smoke Tests job failed in the Android smoke checks on |
Summary
Agents had no single workflow for a whole-app accessibility review. This PR adds
agent-device help accessibility. The topic gives a per-screen audit loop, whole-app coverage rules, and checks that audit cannot do (large text, dark mode, screen reader order and labels, gesture-only actions). It states the scope: audit findings are advisory, and no compliance verdict is given.skills/agent-device/SKILL.md, theagent-setuprule, the root help topic list, andhelp dogfoodPlatform checks point to the topic.help dogfoodtell the agent to act through the followingsnapshot -irefs, found by role and position (rects fromaudit --jsonandsnapshot -i --json). Element-name matching waits until audit prints names (feat(audit): name findings and remove platform chrome noise #4652).accessibility-reviewhelp-conformance case (auditrun, two or more audits,settings text-size, relaunch after the size change). The task states the starting settings, so a static plan can name the size to restore.Validation
6a4ec0ee4f3f58a7afc6eb0b73265ce186f631bc.pnpm check:affected --run: all runnable checks passed (exactCommit=true).vitest run src/commands/schema: 116 passed.pnpm bench:help-conformance --case accessibility-review --runner claude:sonnet --repeat 3: 3/3 trials, 8/8 checks each.Rendered
agent-device help accessibilityOpen in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.