Skip to content

Add dashboard-only private incident notes - #483

Merged
jbrooksuk merged 1 commit into
mainfrom
feature/private-incident-notes
Oct 16, 2026
Merged

jbrooksuk merged 1 commit into
mainfrom
feature/private-incident-notes

Conversation

@jbrooksuk

Copy link
Copy Markdown
Member

Summary

  • Add an optional Private note field to incident create/edit forms, independent of incident visibility.
  • Store notes in a nullable column positioned after message, with a reversible migration.
  • Keep notes out of public surfaces and redact them recursively from incident webhooks without hiding normal model attributes.
  • Preserve existing webhook relationship data and leave the original incident and its loaded relations unchanged.

Verification

  • Full Pest suite: 1,149 passed (4,290 assertions).
  • Pint and git diff checks passed.
  • Browser-verified create/edit forms and saved note persistence.
  • Regression tests cover creating, reloading, editing and clearing notes; guest/authenticated status-page and API privacy; nested incident serialization; and queued update/delete webhooks.
  • The nested webhook regression failed before the fix and passed afterward.

Closes #482

Keep internal incident details separate from the public message and
incident visibility. Exclude notes from incident webhook payloads,
including nested incident copies in loaded updates.

Closes #482

Amp-Thread-ID: https://ampcode.com/threads/T-01a13a0a-30f6-722c-aec3-d20e38738675
Co-authored-by: James Brooks <jbrooksuk@me.com>
@jbrooksuk
jbrooksuk merged commit ebe53a4 into main Oct 16, 2026
23 checks passed
@jbrooksuk
jbrooksuk deleted the feature/private-incident-notes branch October 16, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider a possibility to include private notes under incidents

2 participants