Skip to content

Expose incident private notes via the API behind a dedicated token permission - #485

Open
ashwinuae wants to merge 1 commit into
cachethq:mainfrom
ashwinuae:private-notes-api
Open

ashwinuae wants to merge 1 commit into
cachethq:mainfrom
ashwinuae:private-notes-api

Conversation

@ashwinuae

Copy link
Copy Markdown
Contributor

The private incident notes introduced in #483 were dashboard-only. This PR adds read and write support over the API, gated behind a new token ability.

Changes

  • New ability incident-private-notes.manage, shown in the API key permissions form as "Manage Incident Private Notes".
  • Write: the incident request DTOs accept a nullable private_note. Create and update return 403 if the key is present without the ability.
  • Read: the incident API resource emits private_note only when the token holds the ability. This covers list, show, and include=incident on incident updates.
  • Logged-in sessions now see the note on the API, consistent with the dashboard. The Add dashboard-only private incident notes聽#483 status page test asserting otherwise was split.
  • MCP: create_incident strips private_note before building the DTO.
  • Helper text no longer claims the note is excluded from API responses.

Not changed

  • Webhooks and subscriber notifications stay redacted.
  • Clearing a note over the API is unsupported, matching the nullable date fields where the base DTO drops nulls.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant