chore(deps): clear 11 dev-only Dependabot alerts / INF-1404 - #45
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
Closed
Bump the `dd-trace` and `express` dev dependencies to their latest minor version, and move the `qs` override to `^6.16.0`. This closes INF-1404, INF-1373, INF-1656 and INF-1472 together, because all four packages arrive through the same two dev dependencies. `dd-trace` 5.81.0 dropped `protobufjs` and `shell-quote`, so the bump removes both packages (and `@protobufjs/utf8` under them) from the tree instead of pinning them to a patched version. The `qs` story is longer. The `6.14.2` pin went in to fix INF-897, an `arrayLimit` bypass through comma parsing. That fix only covered a flat key: 6.15.3 and earlier gate the comma-count check on `isFlatArrayValue`, so `a[]=,,,,` skips the check and `arrayLimit` never applies. `6.16.0` removes that gate, and a local check confirms it. Against `arrayLimit` 5 with `throwOnLimitExceeded`, both 6.14.2 and 6.15.3 accept `a[]=` with 25 commas without raising, and 6.16.0 raises. `express` 4.22.2 asks for `qs ~6.15.1`, which caps below the fix, so the override has to stay. It now uses a caret so it can pick up later patches without a manual bump. `npm audit` reports no vulnerabilities. No runtime dependency changes. `pino`, `pino-http` and `redact-object` are untouched, and the published tarball is still the 8 files under `dist/`, so no consumer needs a new release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
minac
force-pushed
the
miguel/INF-1404
branch
from
September 11, 2026 09:36
a151556 to
ae79c45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes INF-1404 (
protobufjs), INF-1373 (@protobufjs/utf8), INF-1656 (shell-quote) and INF-1472 (qs). All four arrive through the same two dev dependencies, so one bump clears 11 alerts (2 critical, 4 high, 5 moderate).dd-trace5.24.0 → 5.126.0,express4.21.1 → 4.22.2.dd-trace5.81.0 droppedprotobufjsandshell-quote, so those two (and@protobufjs/utf8under them) leave the tree instead of getting a pinned patch.qsoverride moves from6.14.2to^6.16.0.Why the
qsoverride staysThe
6.14.2pin came from INF-897, anarrayLimitbypass through comma parsing. It only covered a flat key. 6.15.3 and earlier gate the comma-count check onisFlatArrayValue, soa[]=,,,,skips it. A local check confirms that: againstarrayLimit5 withthrowOnLimitExceeded, both 6.14.2 and 6.15.3 accepta[]=plus 25 commas, and 6.16.0 raises.express4.22.2 asks forqs ~6.15.1, which caps below the fix, so the override can't go yet (the caret lets it pick up later patches on its own).What didn't change
No runtime dependency changes.
pino,pino-httpandredact-objectare untouched, and the published tarball is still the 8 files underdist/, so no consumer needs a release.Review focus
The
qscaret is the part worth a second pair of eyes. A caret on an override is looser than every other pin in this file, and I'm not certain that's the right call here.How to verify
npm ci, thennpm run build. It's green on this branch.npm audit. It reports no vulnerabilities.npm ls protobufjs shell-quote. Neither package is in the tree.How does it look
N/A, non-visual.
-- Written by Miguel's Claude