Skip to content

chore(deps): clear 11 dev-only Dependabot alerts / INF-1404 - #45

Merged
minac merged 1 commit into
mainfrom
miguel/INF-1404
Sep 11, 2026
Merged

minac merged 1 commit into
mainfrom
miguel/INF-1404

Conversation

@minac

@minac minac commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes INF-1404 (protobufjs), INF-1373 (@protobufjs/utf8), INF-1656 (shell-quote) and INF-1472 (qs). All four arrive through the same two dev dependencies, so one bump clears 11 alerts (2 critical, 4 high, 5 moderate).

  • dd-trace 5.24.0 → 5.126.0, express 4.21.1 → 4.22.2.
  • dd-trace 5.81.0 dropped protobufjs and shell-quote, so those two (and @protobufjs/utf8 under them) leave the tree instead of getting a pinned patch.
  • The qs override moves from 6.14.2 to ^6.16.0.

Why the qs override stays

The 6.14.2 pin came from INF-897, an arrayLimit bypass through comma parsing. It only covered a flat key. 6.15.3 and earlier gate the comma-count check on isFlatArrayValue, so a[]=,,,, skips it. A local check confirms that: against arrayLimit 5 with throwOnLimitExceeded, both 6.14.2 and 6.15.3 accept a[]= plus 25 commas, and 6.16.0 raises. express 4.22.2 asks for qs ~6.15.1, which caps below the fix, so the override can't go yet (the caret lets it pick up later patches on its own).

What didn't change

No runtime dependency changes. pino, pino-http and redact-object are untouched, and the published tarball is still the 8 files under dist/, so no consumer needs a release.

Review focus

The qs caret is the part worth a second pair of eyes. A caret on an override is looser than every other pin in this file, and I'm not certain that's the right call here.

How to verify

  1. Run npm ci, then npm run build. It's green on this branch.
  2. Run npm audit. It reports no vulnerabilities.
  3. Run npm ls protobufjs shell-quote. Neither package is in the tree.

How does it look

N/A, non-visual.

-- Written by Miguel's Claude

@minac minac self-assigned this Sep 11, 2026
@minac
minac requested a review from a team as a code owner September 11, 2026 09:28
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2261fbec-75f4-44f3-b6c3-2a1f3cd12b3b


Comment @coderabbitai help to get the list of available commands.

@minac minac mentioned this pull request Sep 11, 2026
Bump the `dd-trace` and `express` dev dependencies to their latest minor
version, and move the `qs` override to `^6.16.0`. This closes INF-1404,
INF-1373, INF-1656 and INF-1472 together, because all four packages
arrive through the same two dev dependencies.

`dd-trace` 5.81.0 dropped `protobufjs` and `shell-quote`, so the bump
removes both packages (and `@protobufjs/utf8` under them) from the tree
instead of pinning them to a patched version.

The `qs` story is longer. The `6.14.2` pin went in to fix INF-897, an
`arrayLimit` bypass through comma parsing. That fix only covered a flat
key: 6.15.3 and earlier gate the comma-count check on `isFlatArrayValue`,
so `a[]=,,,,` skips the check and `arrayLimit` never applies. `6.16.0`
removes that gate, and a local check confirms it. Against `arrayLimit` 5
with `throwOnLimitExceeded`, both 6.14.2 and 6.15.3 accept `a[]=` with 25
commas without raising, and 6.16.0 raises. `express` 4.22.2 asks for
`qs ~6.15.1`, which caps below the fix, so the override has to stay. It
now uses a caret so it can pick up later patches without a manual bump.
`npm audit` reports no vulnerabilities.

No runtime dependency changes. `pino`, `pino-http` and `redact-object`
are untouched, and the published tarball is still the 8 files under
`dist/`, so no consumer needs a new release.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@minac
minac merged commit 5b5d9bf into main Sep 11, 2026
3 checks passed
@minac
minac deleted the miguel/INF-1404 branch September 11, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant