Repository navigation
Default to two dedicated automation writer replicas #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Erin McNulty (erin2722)
wants to merge
1
commit into
main
Choose a base branch
from
erin/default-two-automation-writers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−8
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,6 +88,7 @@ brainstore: | |
| volume: | ||
| size: "100Gi" | ||
| automationwriter: | ||
| replicas: 0 | ||
| volume: | ||
| size: "200Gi" | ||
| writer: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
braintrust/tests/brainstore-automationwriter-defaults_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| suite: test default automation writer isolation | ||
| templates: | ||
| - brainstore-automationwriter-deployment.yaml | ||
| - brainstore-automationwriter-configmap.yaml | ||
| - brainstore-writer-configmap.yaml | ||
| - api-configmap.yaml | ||
| tests: | ||
| - it: should run two dedicated automation writers by default | ||
| template: brainstore-automationwriter-deployment.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.replicas | ||
| value: 2 | ||
| - it: should run only automations on the dedicated pool by default | ||
| template: brainstore-automationwriter-configmap.yaml | ||
| asserts: | ||
| - equal: | ||
| path: data.BRAINSTORE_WRITER_LOOP_CONFIG | ||
| value: include:automations | ||
| - it: should exclude automations from regular writers by default | ||
| template: brainstore-writer-configmap.yaml | ||
| asserts: | ||
| - equal: | ||
| path: data.BRAINSTORE_WRITER_LOOP_CONFIG | ||
| value: exclude:automations | ||
| - it: should route automation queries to the dedicated pool by default | ||
| template: api-configmap.yaml | ||
| release: | ||
| namespace: braintrust | ||
| asserts: | ||
| - equal: | ||
| path: data.BRAINSTORE_AUTOMATION_WRITER_URL | ||
| value: http://brainstore-automationwriter.braintrust:4000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an install or upgrade adopts this new default, the chart immediately publishes
BRAINSTORE_AUTOMATION_WRITER_URLand configures regular writers to exclude automations, but the API startup gate does not wait for the automation-writer Deployment. As documented inbraintrust/README.md, enabling the pool during an upgrade can temporarily run automations on both pools, while an unschedulable new pool—each replica requests 32 CPU and 128Gi—can instead leave no Ready process handling automations after the regular-writer rollout. Keep the default at zero or add sequencing/readiness protection before enabling it automatically.AGENTS.md reference: AGENTS.md:L99-L101
Useful? React with 👍 / 👎.