Repository navigation
Default to two dedicated automation writer replicas - #115
Erin McNulty (erin2722) wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61e1a916c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| service: {} | ||
| pod: {} | ||
| replicas: 0 | ||
| replicas: 2 |
There was a problem hiding this comment.
Keep automation writers opt-in until rollout is coordinated
When an install or upgrade adopts this new default, the chart immediately publishes BRAINSTORE_AUTOMATION_WRITER_URL and configures regular writers to exclude automations, but the API startup gate does not wait for the automation-writer Deployment. As documented in braintrust/README.md, enabling the pool during an upgrade can temporarily run automations on both pools, while an unschedulable new pool—each replica requests 32 CPU and 128Gi—can instead leave no Ready process handling automations after the regular-writer rollout. Keep the default at zero or add sequencing/readiness protection before enabling it automatically.
AGENTS.md reference: AGENTS.md:L99-L101
Useful? React with 👍 / 👎.
Default the chart and GKE examples to two dedicated Brainstore automation writer replicas. Existing templates isolate the automation loop from regular writers and publish the dedicated Service endpoint to the APIs. Update the values guidance and add coverage for the default replica count, loop isolation, and API routing.
This adds two pods at the existing resource requests (32 CPU and 128Gi memory each). Explicit replica overrides and retained values remain authoritative. No chart version or image tag changes are included.
Input matrix:
Validation:
./test.sh(424 unit tests, Python startup-gate tests, all CI cloud renders, strict Helm lint); separate enabled-pool renders for AWS, Google, Azure, and minimal configuration.