Skip to content

Fix deprecated-copy warnings in polynomial.hpp #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 3 commits into from
Sep 13, 2026
Merged

Fix deprecated-copy warnings in polynomial.hpp #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d372a0
Fix deprecated-copy warnings in polynomial.hpp
Flamefire Sep 13, 2026
32fcd75
Reorder reference member functions
Flamefire Sep 13, 2026
c6e66c5
Default copy/move ctors
Flamefire Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions include/boost/random/detail/polynomial.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,12 @@ class polynomial
public:
reference(digit_t &value, int idx)
: _value(value), _idx(idx) {}
operator bool() const { return (_value & (digit_t(1) << _idx)) != 0; }
reference(const reference& other) = default;
reference(reference&& other) = default;
reference &operator=(const reference &other)
{
return *this = static_cast<bool>(other);
}
reference& operator=(bool b)
{
if(b) {
Expand All @@ -294,16 +299,14 @@ class polynomial
}
return *this;
}
operator bool() const { return (_value & (digit_t(1) << _idx)) != 0; }


reference &operator^=(bool b)
{
_value ^= (digit_t(b) << _idx);
return *this;
}

reference &operator=(const reference &other)
{
return *this = static_cast<bool>(other);
}
private:
digit_t &_value;
int _idx;
Expand Down Expand Up @@ -339,7 +342,7 @@ class polynomial
friend polynomial operator*(const polynomial &lhs, const polynomial &rhs);
friend polynomial mod_pow_x(boost::uintmax_t exponent, polynomial mod);
private:
std::vector<polynomial_ops::digit_t> _storage;
std::vector<digit_t> _storage;
std::size_t _size;
void ensure_bit(std::size_t i)
{
Expand Down
Loading