Skip to content

Fix deprecated-copy warnings in polynomial.hpp - #166

Merged
mborland merged 3 commits into
boostorg:developfrom
Flamefire:patch-1
Sep 13, 2026
Merged

mborland merged 3 commits into
boostorg:developfrom
Flamefire:patch-1

Conversation

@Flamefire

@Flamefire Flamefire commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Explicitly define the copy/move constructor as the implicit copy constructor for 'reference' is deprecated because it has a user-declared copy assignment operator

I moved reference &operator^=(bool b) to the bottom to avoid it being inside the conversion operators, so they can be closer together making reasoning about them easier

I noticed that operator bool should likely be explicit

Alternative to #111 after #110 got closed even though considered correct by @mborland

Explicitely delete the copy constructor as the implicit copy constructor for 'reference' is deprecated because it has a user-declared copy assignment operator
@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.79%. Comparing base (21b0544) to head (c6e66c5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #166   +/-   ##
========================================
  Coverage    95.79%   95.79%           
========================================
  Files          117      117           
  Lines         7660     7660           
========================================
  Hits          7338     7338           
  Misses         322      322           
Files with missing lines Coverage Δ
include/boost/random/detail/polynomial.hpp 96.93% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b0544...c6e66c5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We need to be able return `reference`

@mborland mborland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! Will merge once the CI finishes.

@mborland
mborland merged commit f1983c8 into boostorg:develop Sep 13, 2026
63 checks passed
@Flamefire
Flamefire deleted the patch-1 branch September 13, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants