Skip to content

feat: assign auto-incremented ids to code blocks so anonynous functions can be identified in vm trace #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedel1043 merged 5 commits into from
Mar 9, 2026
Merged

feat: assign auto-incremented ids to code blocks so anonynous functions can be identified in vm trace #4754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47a7f18
feat: assign ids to anonymous functions at runtime to identify them i…
ashddev Feb 27, 2026
8fce6b4
refactor: use thread local counter to assign ids to codeblocks for si…
ashddev Mar 2, 2026
7c7f0d2
refactor: use utility function for getting next codeblock id
ashddev Mar 4, 2026
cbc606b
fix: remove `trace` feature gating from `debug_id` so bytecode displa…
ashddev Mar 8, 2026
3066f77
chore: update insta snapshots to reflect formatting changes to compil…
ashddev Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/engine/src/bytecompiler/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2535,6 +2535,7 @@ impl<'ctx> ByteCompiler<'ctx> {
global_lexs: self.global_lexs.into_boxed_slice(),
global_fns: self.global_fns.into_boxed_slice(),
global_vars: self.global_vars.into_boxed_slice(),
debug_id: CodeBlock::get_next_codeblock_id(),
}
}

Expand Down
25 changes: 24 additions & 1 deletion core/engine/src/vm/code_block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ pub struct CodeBlock {
pub(crate) global_lexs: Box<[u32]>,
pub(crate) global_fns: Box<[GlobalFunctionBinding]>,
pub(crate) global_vars: Box<[u32]>,

// Used for identifying anonymous functions in compiled output and call frames.
pub(crate) debug_id: u64,
}

/// ---- `CodeBlock` public API ----
Expand Down Expand Up @@ -194,6 +197,7 @@ impl CodeBlock {
global_lexs: Box::default(),
global_fns: Box::default(),
global_vars: Box::default(),
debug_id: CodeBlock::get_next_codeblock_id(),
}
}

Expand Down Expand Up @@ -345,6 +349,18 @@ impl CodeBlock {
pub(crate) fn source_info(&self) -> &SourceInfo {
&self.source_info
}

pub(crate) fn get_next_codeblock_id() -> u64 {
thread_local! {
static CODEBLOCK_ID_COUNTER: Cell<u64> = const { Cell::new(0) };
}

CODEBLOCK_ID_COUNTER.with(|c| {
let id = c.get();
c.set(id + 1);
id
})
}
}

/// ---- `CodeBlock` private API ----
Expand Down Expand Up @@ -913,7 +929,14 @@ impl Display for CodeBlock {
writeln!(
f,
"{:-^80}",
format!("Compiled Output: '{}'", name.to_std_string_escaped()),
format!(
" Compiled Output: {} ",
if name.is_empty() {
format!("[anon#{}]", self.debug_id)
} else {
format!("'{}'", name.to_std_string_escaped())
}
),
)?;
writeln!(
f,
Expand Down
9 changes: 7 additions & 2 deletions core/engine/src/vm/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,13 @@ impl Context {
" VM Start ".to_string()
} else {
format!(
" Call Frame -- {} ",
frame.code_block().name().to_std_string_escaped()
" Call Frame '{}'{} ",
frame.code_block().name().to_std_string_escaped(),
if frame.code_block().name().is_empty() {
format!(" [anon#{}]", frame.code_block().debug_id)
} else {
String::new()
}
)
};

Expand Down
2 changes: 1 addition & 1 deletion tests/insta-bytecode/src/snapshots/insta_bytecode__compile_bytecode@basic-loop.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source: tests/insta-bytecode/src/lib.rs
expression: output
input_file: tests/insta-bytecode/scripts/basic-loop.js
---
---------------------------Compiled Output: '<main>'----------------------------
-------------------------- Compiled Output: '<main>' ---------------------------
Location Handler Opcode Operands
000000 PushZero dst:r02
000005 Jump address:000014
Expand Down
2 changes: 1 addition & 1 deletion ...nsta-bytecode/src/snapshots/insta_bytecode__compile_bytecode@double-loop-function.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source: tests/insta-bytecode/src/lib.rs
expression: output
input_file: tests/insta-bytecode/scripts/double-loop-function.js
---
---------------------------Compiled Output: '<main>'----------------------------
-------------------------- Compiled Output: '<main>' ---------------------------
Location Handler Opcode Operands
000000 PushZero dst:r02
000005 Jump address:000014
Expand Down
2 changes: 1 addition & 1 deletion tests/insta-bytecode/src/snapshots/insta_bytecode__compile_bytecode@new.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source: tests/insta-bytecode/src/lib.rs
expression: output
input_file: tests/insta-bytecode/scripts/new.js
---
---------------------------Compiled Output: '<main>'----------------------------
-------------------------- Compiled Output: '<main>' ---------------------------
Location Handler Opcode Operands
000000 PushScope scope_index:1
000005 GetFunction index:2, dst:r01
Expand Down
Loading