feat: assign auto-incremented ids to anonynous functions to identify them in vm trace#4754
Open
ashddev wants to merge 1 commit intoboa-dev:mainfrom
Open
feat: assign auto-incremented ids to anonynous functions to identify them in vm trace#4754ashddev wants to merge 1 commit intoboa-dev:mainfrom
ashddev wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
|
jedel1043
requested changes
Feb 27, 2026
Member
jedel1043
left a comment
There was a problem hiding this comment.
Very nice contribution! We can simplify this a bit more with a thread local counter.
Comment on lines
+183
to
+184
| #[cfg(feature = "trace")] | ||
| anon_debug_id: Cell::new(None), |
Member
There was a problem hiding this comment.
I'd say for simplicitly's sake, we can just assign a incremental ID to every CodeBlock on the same thread. We do something very similar in Context:
boa/core/engine/src/context/mod.rs
Lines 46 to 48 in f22ef44
boa/core/engine/src/context/mod.rs
Line 1115 in f22ef44
Since any CodeBlock can be executed by any Context but CodeBlock's cannot be sent between threads, a thread local counter should be enough for this purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #4742
It changes the following:
anon_debug_idtoCodeBlocks.This is my first contribution to Boa, and I’m happy to make any changes based on feedback :)