Refs #159: migrate Transport.LiteDb.Tests to MSTest assertions (Phase 3 PR A)

[blehnen]

Part of #159 (replace FluentAssertions with MSTest assertions). Phase 3, PR A of 2.

Migrates DotNetWorkQueue.Transport.LiteDb.Tests (77 .Should() sites across 5 files) from FluentAssertions to built-in MSTest assertions and removes the project's FluentAssertions PackageReference. Adds a ProjectReference to DotNetWorkQueue.Tests.Shared for the one non-1:1 pattern.

Files

• Basic/QueryMessageHistoryHandlerTests.cs (4)
• Basic/QueryHandler/DoesJobExistQueryHandlerTests.cs (7)
• Basic/QueryHandler/GetJobIdQueryHandlerTests.cs (4)
• Basic/CommandHandler/SetJobLastKnownEventCommandHandlerTests.cs (13)
• Basic/WriteMessageHistoryHandlerTests.cs (49)
• csproj: +Tests.Shared ProjectReference, −FluentAssertions

Mapping notes

• Expected-first Assert.AreEqual; .Should().Be(x)→AreEqual, HaveCount(n)→AreEqual(n, .Count), NotBeNull/BeNull→IsNotNull/IsNull.
• BeEquivalentTo(byte[]) → AssertHelper.AreEquivalent (order-insensitive, matches FA default).
• BeGreaterThan(0)/BeGreaterThanOrEqualTo(0) → Assert.IsTrue(x > 0)/(x >= 0).
• NotThrow() → bare act();.

Verification

• dotnet build -c Release (TreatWarningsAsErrors) → 0 warnings, 0 errors.
• dotnet test -c Release → 168/168 passed.
• Project grep for FluentAssertions/.Should() → zero.
• Source/Directory.Packages.props FA entry intentionally left in place (removed in the final Replace FluentAssertions with MSTest assertions (license: 6.12.2 is last MIT release) #159 phase).

Test-only; no production code change, no version bump.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated test assertions to use the built-in test framework consistently.
  • Added broader coverage helpers for comparing complex values in history-related tests.
  • Removed an unused test dependency and adjusted test project references accordingly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c63f4886-e07f-4d24-9dc4-287e5390127f

📥 Commits

Reviewing files that changed from the base of the PR and between ef9d7d5 and 9d68d5e.

📒 Files selected for processing (6)

• Source/DotNetWorkQueue.Transport.LiteDb.Tests/Basic/CommandHandler/SetJobLastKnownEventCommandHandlerTests.cs
• Source/DotNetWorkQueue.Transport.LiteDb.Tests/Basic/QueryHandler/DoesJobExistQueryHandlerTests.cs
• Source/DotNetWorkQueue.Transport.LiteDb.Tests/Basic/QueryHandler/GetJobIdQueryHandlerTests.cs
• Source/DotNetWorkQueue.Transport.LiteDb.Tests/Basic/QueryMessageHistoryHandlerTests.cs
• Source/DotNetWorkQueue.Transport.LiteDb.Tests/Basic/WriteMessageHistoryHandlerTests.cs
• Source/DotNetWorkQueue.Transport.LiteDb.Tests/DotNetWorkQueue.Transport.LiteDb.Tests.csproj

---

📝 Walkthrough

Walkthrough

This PR migrates test assertions in the LiteDb transport test project from FluentAssertions to MSTest's built-in Assert API. It removes FluentAssertions imports, rewrites assertion calls, adds a shared test utilities project reference, and removes the FluentAssertions package dependency.

Changes

LiteDb Test Assertion Migration

Layer / File(s)	Summary
Command handler test migration Basic/CommandHandler/SetJobLastKnownEventCommandHandlerTests.cs	FluentAssertions import removed and job insert/update/count assertions rewritten to MSTest `Assert.AreEqual`.
Query handler test migration Basic/QueryHandler/DoesJobExistQueryHandlerTests.cs, Basic/QueryHandler/GetJobIdQueryHandlerTests.cs	Status and job-id result assertions across multiple test methods converted from `.Should().Be(...)` to `Assert.AreEqual(...)`.
Message history query test migration Basic/QueryMessageHistoryHandlerTests.cs	Null and duration assertions rewritten using `Assert.IsNotNull`, `Assert.AreEqual`, and `Assert.IsNull`.
Message history write lifecycle test migration Basic/WriteMessageHistoryHandlerTests.cs	Enqueue, processing, complete, error, rollback, delete, expire, and full-lifecycle assertions rewritten to MSTest calls; body/header comparisons use `AssertHelper.AreEquivalent`; "no throw" checks replaced with direct action invocation.
Project reference and package updates DotNetWorkQueue.Transport.LiteDb.Tests.csproj	Adds a project reference to `DotNetWorkQueue.Tests.Shared` and removes the `FluentAssertions` package reference.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related issues

• Replace FluentAssertions with MSTest assertions (license: 6.12.2 is last MIT release) #159: Continues the same FluentAssertions-to-MSTest test refactor, replacing .Should() calls with Assert.* and removing the FluentAssertions package reference.

Poem

A bunny hopped through lines of test,
Swapped "Should().Be" for MSTest's best,
No throw? Just run it, plain and true,
FluentAssertions bids adieu,
Shared helpers now join the nest 🐰✅

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: migrating Transport.LiteDb.Tests to MSTest assertions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud