Remove FluentAssertions entirely — CPM + dead refs (closes #159)#178
Merged
Conversation
…rences (closes #159) All FluentAssertions .Should() assertions were migrated to MSTest across Phases 2-7; every remaining reference was dead. Removes atomically (CPM requires PackageVersion + all PackageReference to go together, else NU1010): - central <PackageVersion Include="FluentAssertions"> from Directory.Packages.props - 17 dead <PackageReference Include="FluentAssertions"> lines across test projects - dead net452-era packages.config (SqlServer.Tests) still listing FluentAssertions 4.19.4 Test-only: no production assembly touched, no <Version> change. Full-solution Release build green (0 errors); solution-wide grep for .Should()/using FluentAssertions/FA package refs = 0. Closes #159 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
💤 Files with no reviewable changes (19)
📝 WalkthroughWalkthroughThe FluentAssertions package version is removed from the central Directory.Packages.props file, and the FluentAssertions PackageReference is removed from 17 test/integration test project files across the solution. CompareNETObjects is added as a replacement reference in several projects, and a stale packages.config file is emptied. ChangesFluentAssertions Removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 87.45% 87.50% +0.04%
==========================================
Files 1024 1024
Lines 33905 33905
Branches 2870 2870
==========================================
+ Hits 29652 29668 +16
+ Misses 3374 3361 -13
+ Partials 879 876 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final phase of #159. All FluentAssertions
.Should()assertions were migrated to MSTest across Phases 2–7 (PRs #171–#177); every remaining FA reference is now dead. This PR removes them and closes out the issue.Removed (atomic — Central Package Management requires the
PackageVersionand everyPackageReferenceto land together, else the build failsNU1010):<PackageVersion Include="FluentAssertions" Version="6.12.2" />fromSource/Directory.Packages.props<PackageReference Include="FluentAssertions" />lines across unit / integration / LINQ test projectspackages.config(SqlServer.Tests) still listingFluentAssertions 4.19.4— the project is SDK-style withPackageReference, so this file was already ignored by the buildDiff shape: pure deletions, only
.csproj/.props/packages.configtouched. No production assembly, no<Version>change — test-only.Verification
git grep(tracked files): 0.Should(), 0using FluentAssertions, 0 FA package references (PackageReference/PackageVersion/packages.config).dotnet build Source/DotNetWorkQueue.sln -c Release -p:CI=true→ 0 errors (4 pre-existing warnings, none FA-related).FluentAssertionsstring in tracked source is a single XML doc comment inAssertHelper.csdocumenting the migration rationale — intentional, not a dependency.Jenkins covers the integration suites across stages.
Closes #159
Summary by CodeRabbit