Skip to content

Cbor header fix for empty vs no payload #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbaluja wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −3
Open

Cbor header fix for empty vs no payload #3745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6355b16
Fix CBOR_CONTENT_TYPE_HEADER be sent when there is a request payload
sbaluja Mar 10, 2026
6a10eaf
Updated cloudwatch model files
sbaluja Mar 10, 2026
c7bb96b
Reorder header for cbor content type
sbaluja Mar 10, 2026
6d7c3d9
Updated cloudwatch model files
sbaluja Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...ain/java/com/amazonaws/util/awsclientgenerator/generators/cpp/CborCppClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ else if (shape.isRequest()) {
Map<String, String> cborSpecificHeaders = new HashMap<>();
cborSpecificHeaders.put("Aws::Http::ACCEPT_HEADER", "Aws::CBOR_CONTENT_TYPE");
cborSpecificHeaders.put("Aws::Http::SMITHY_PROTOCOL_HEADER", "Aws::RPC_V2_CBOR");
if(shape.hasMembers()){
cborSpecificHeaders.put("Aws::Http::CONTENT_TYPE_HEADER", "Aws::CBOR_CONTENT_TYPE");
}
context.put("requestSpecificHeaders", cborSpecificHeaders);
template = velocityEngine.getTemplate("/com/amazonaws/util/awsclientgenerator/velocity/cpp/cbor/CborRequestSource.vm", StandardCharsets.UTF_8.name());
}
Expand Down
3 changes: 3 additions & 0 deletions ...in/resources/com/amazonaws/util/awsclientgenerator/velocity/cpp/cbor/CborRequestSource.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@
Aws::Http::HeaderValueCollection ${typeInfo.className}::GetRequestSpecificHeaders() const
{
Aws::Http::HeaderValueCollection headers;
#if($operation.hasRequest())
Copy link
Contributor

@sbiscigl sbiscigl Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit - can we move this to above the for loop so there is no git diff on unchanged clients?

headers.emplace(Aws::Http::CONTENT_TYPE_HEADER, Aws::CBOR_CONTENT_TYPE);
#end
#foreach($headerEntry in $requestSpecificHeaders.entrySet())
headers.emplace(${headerEntry.key}, ${headerEntry.value});
#end
Expand Down