Open
Conversation
pulimsr
approved these changes
Mar 10, 2026
sbiscigl
reviewed
Mar 10, 2026
| #foreach($headerEntry in $requestSpecificHeaders.entrySet()) | ||
| headers.emplace(${headerEntry.key}, ${headerEntry.value}); | ||
| #end | ||
| #if($operation.hasRequest()) |
Contributor
There was a problem hiding this comment.
small nit - can we move this to above the for loop so there is no git diff on unchanged clients?
sbaluja
force-pushed
the
cbor-header-fix
branch
from
d0aab54 to
6d7c3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.