Skip to content

feat: example scripts moved to root #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SilanHe merged 3 commits into from
Jun 4, 2026
+36 −30
Merged

feat: example scripts moved to root #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
749f4d1
feat: example scripts moved to root
hsilan Jun 4, 2026
1b3b2e7
ci: fix missing otel dependency in deploy-examples
hsilan Jun 4, 2026
05a79bc
ci: update dev-examples and dev-otel env
hsilan Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/deploy-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,12 @@ jobs:
- name: Install Hatch
run: pip install hatch
- name: Build examples
working-directory: ./packages/aws-durable-execution-sdk-python-examples
run: |
hatch run -- examples:pip install -e ../aws-durable-execution-sdk-python
hatch run -- examples:pip install -e packages/aws-durable-execution-sdk-python packages/aws-durable-execution-sdk-python-otel
Copy link
Copy Markdown
Contributor Author

@SilanHe SilanHe Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the crux of the ci fix

hatch run examples:build
- name: Deploy Lambda function - ${{ matrix.example.name }}
id: deploy
working-directory: ./packages/aws-durable-execution-sdk-python-examples
env:
AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
LAMBDA_ENDPOINT: "https://lambda.us-west-2.amazonaws.com"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,15 @@ jobs:
rm -rf /tmp/aws/
- name: Deploy and test examples
working-directory: language-sdk/packages/aws-durable-execution-sdk-python-examples
working-directory: language-sdk
env:
AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
LAMBDA_ENDPOINT: "https://lambda.us-west-2.amazonaws.com"
INVOKE_ACCOUNT_ID: ${{ secrets.INVOKE_ACCOUNT_ID }}
KMS_KEY_ARN: ${{ secrets.KMS_KEY_ARN }}
run: |
echo "Building examples..."
hatch run -- examples:pip install -e ../testing-sdk
hatch run -- examples:pip install -e packages/testing-sdk
hatch run examples:build
# Get first integration example for testing
Expand Down
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ hatch fmt
# Build distribution
hatch build

# Examples deployment (from examples package)
cd ../aws-durable-execution-sdk-python-examples
# Examples deployment (from repo root)
hatch run examples:build
hatch run examples:deploy "Hello World"
```
Expand Down Expand Up @@ -309,7 +308,7 @@ tests/mypackage/mymodule_test.py
## Examples and Deployment

The project includes a unified CLI tool for managing examples, deployment, and AWS account setup.
Run these commands from the examples package directory (`packages/aws-durable-execution-sdk-python-examples`).
Run these commands from the **repository root**.

To run examples tests from the repo root:
```bash
Expand Down
14 changes: 1 addition & 13 deletions packages/aws-durable-execution-sdk-python-examples/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,12 @@ requires-python = ">=3.11"
dependencies = [
"aws-durable-execution-sdk-python",
"aws-durable-execution-sdk-python-testing",
"aws-durable-execution-sdk-python-otel"
]

[tool.hatch.build.targets.wheel]
packages = ["src"]

[tool.hatch.envs.examples.scripts]
cli = "python cli.py {args}"
bootstrap = "python cli.py bootstrap"
generate-sam-template = "python scripts/generate_sam_template.py"
build = "python cli.py build"
deploy = "python cli.py deploy {args}"
invoke = "python cli.py invoke {args}"
get = "python cli.py get {args}"
history = "python cli.py history {args}"
policy = "python cli.py policy {args}"
list = "python cli.py list"
clean = "rm -rf build .aws-sam *.zip"

[tool.ruff]
line-length = 88
target-version = "py311"
Expand Down
18 changes: 9 additions & 9 deletions packages/aws-durable-execution-sdk-python-examples/test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ Tests run against the in-memory `DurableFunctionTestRunner`:
- ✅ Validates local runner behavior

```bash
# Run all example tests locally (default)
hatch run test:examples
# Run all example tests locally (default, from repo root)
hatch run dev-examples:test

# Run with explicit mode flag
pytest --runner-mode=local -m example examples/test/
pytest --runner-mode=local -m example packages/aws-durable-execution-sdk-python-examples/test/

# Run specific test
pytest --runner-mode=local -k test_hello_world examples/test/
pytest --runner-mode=local -k test_hello_world packages/aws-durable-execution-sdk-python-examples/test/
```

### Cloud Mode (Integration)
Expand All @@ -30,7 +30,7 @@ Tests run against actual AWS Lambda functions using `DurableFunctionCloudTestRun
- ⚠️ Requires deployed functions

```bash
# Deploy function first
# Deploy function first (from repo root)
hatch run examples:deploy "hello world" --function-name HelloWorld-Test

# Set environment variables for cloud testing
Expand All @@ -39,10 +39,10 @@ export LAMBDA_ENDPOINT=https://lambda.us-west-2.amazonaws.com
export QUALIFIED_FUNCTION_NAME="HelloWorld-Test:\$LATEST"
export LAMBDA_FUNCTION_TEST_NAME="hello world"

# Run tests
pytest --runner-mode=cloud -k test_hello_world examples/test/
# Run tests (from repo root)
pytest --runner-mode=cloud -k test_hello_world packages/aws-durable-execution-sdk-python-examples/test/

# Or using hatch
# Or using hatch (from repo root)
hatch run test:examples-integration -k test_hello_world
```

Expand Down Expand Up @@ -116,4 +116,4 @@ result = runner.run(input="test", timeout=120) # Increase to 120s

**Solution**: Install dependencies:
```bash
hatch run test:examples # Installs dependencies automatically
hatch run dev-examples:test # Installs dependencies automatically
21 changes: 21 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ typecheck = "mypy --install-types --non-interactive packages/aws-durable-executi
workspace.members = [
"packages/aws-durable-execution-sdk-python",
"packages/aws-durable-execution-sdk-python-examples",
"packages/aws-durable-execution-sdk-python-otel",
]
dependencies = [
"pytest",
Expand Down Expand Up @@ -118,6 +119,26 @@ pre-install-commands = [
[tool.hatch.envs.test-pypi-examples.scripts]
test = "pytest packages/aws-durable-execution-sdk-python-examples/test {args}"

[tool.hatch.envs.examples]
workspace.members = [
"packages/aws-durable-execution-sdk-python",
"packages/aws-durable-execution-sdk-python-examples",
"packages/aws-durable-execution-sdk-python-otel",
]

[tool.hatch.envs.examples.scripts]
cli = "python packages/aws-durable-execution-sdk-python-examples/cli.py {args}"
bootstrap = "python packages/aws-durable-execution-sdk-python-examples/cli.py bootstrap"
generate-sam-template = "python packages/aws-durable-execution-sdk-python-examples/scripts/generate_sam_template.py"
build = "python packages/aws-durable-execution-sdk-python-examples/cli.py build"
deploy = "python packages/aws-durable-execution-sdk-python-examples/cli.py deploy {args}"
invoke = "python packages/aws-durable-execution-sdk-python-examples/cli.py invoke {args}"
get = "python packages/aws-durable-execution-sdk-python-examples/cli.py get {args}"
history = "python packages/aws-durable-execution-sdk-python-examples/cli.py history {args}"
policy = "python packages/aws-durable-execution-sdk-python-examples/cli.py policy {args}"
list = "python packages/aws-durable-execution-sdk-python-examples/cli.py list"
Copy link
Copy Markdown
Contributor

@zhongkechen zhongkechen Jun 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks weird to me running a script directly from a sub-package at the root level. Hoping for a nicer solution: #404 or #383

clean = "rm -rf packages/aws-durable-execution-sdk-python-examples/build packages/aws-durable-execution-sdk-python-examples/.aws-sam packages/aws-durable-execution-sdk-python-examples/*.zip"

[tool.ruff]
line-length = 88
target-version = "py311"
Expand Down
Loading