feat: example scripts moved to root#418
Merged
Merged
Conversation
Contributor
Author
|
I think think we also need to add https://github.com/aws/aws-durable-execution-sdk-python/actions/runs/26921643616/workflow?pr=417#L63 but I'm leaving it as is for now to repro issue Frank ran in to here |
Contributor
|
We do need a long term solution for examples. Maybe track it in this issue #404 |
zhongkechen
approved these changes
Jun 4, 2026
| get = "python packages/aws-durable-execution-sdk-python-examples/cli.py get {args}" | ||
| history = "python packages/aws-durable-execution-sdk-python-examples/cli.py history {args}" | ||
| policy = "python packages/aws-durable-execution-sdk-python-examples/cli.py policy {args}" | ||
| list = "python packages/aws-durable-execution-sdk-python-examples/cli.py list" |
Contributor
SilanHe
commented
Jun 4, 2026
| working-directory: ./packages/aws-durable-execution-sdk-python-examples | ||
| run: | | ||
| hatch run -- examples:pip install -e ../aws-durable-execution-sdk-python | ||
| hatch run -- examples:pip install -e packages/aws-durable-execution-sdk-python packages/aws-durable-execution-sdk-python-otel |
Contributor
Author
There was a problem hiding this comment.
this is the crux of the ci fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Moving the scripts defined in the
aws-durable-execution-sdk-python-examples/pyproject.tomlto the rootpyproject.tomlfor consistency.Also fixing a ci bug from this PR. Frank is adding dependency on otel package to examples but our ci only installs the sdk locally. Added otel package as part of install.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.