Skip to content

Fix codeartifact login --namespace to accept uppercase characters #10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carschandler wants to merge 1 commit into
base: v2
Choose a base branch
from
+6 −1
Open

Fix codeartifact login --namespace to accept uppercase characters #10208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion awscli/customizations/codeartifact/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ def _run_command(self, tool, command):
@classmethod
def get_scope(cls, namespace):
# Regex for valid scope name
valid_scope_name = re.compile('^(@[a-z0-9-~][a-z0-9-._~]*)')
valid_scope_name = re.compile('^(@[a-zA-Z0-9-~][a-zA-Z0-9-._~]*)')

if namespace is None:
return namespace
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/customizations/codeartifact/test_adapter_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,11 @@ def test_get_scope_without_prefix(self):
scope = self.test_subject.get_scope(f'@{self.namespace}')
self.assertEqual(scope, expected_value)

def test_get_scope_with_uppercase(self):
expected_value = '@Transform9'
scope = self.test_subject.get_scope('Transform9')
self.assertEqual(scope, expected_value)

def test_get_commands(self):
commands = self.test_subject.get_commands(
self.endpoint, self.auth_token
Expand Down