Fix codeartifact login --namespace to accept uppercase characters#10208
Open
carschandler wants to merge 1 commit intoaws:v2from
Open
Fix codeartifact login --namespace to accept uppercase characters#10208carschandler wants to merge 1 commit intoaws:v2from
carschandler wants to merge 1 commit intoaws:v2from
Conversation
The npm scope name regex in NpmLogin.get_scope() only allowed lowercase letters (a-z), causing valid namespace values containing uppercase characters to be rejected with a misleading error about URL-safe characters. npm scopes are case-insensitive, so uppercase letters should be permitted. This adds A-Z to both character classes in the regex and adds a corresponding unit test. Fixes aws#10207
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NpmLogin.get_scope()only allowed lowercase letters (a-z), causing valid--namespacevalues containing uppercase characters to be rejected with a misleading error about URL-safe characters.A-Zto both character classes in the validation regex.Fixes #10207