Repository navigation
ci(e2e): the nightly also runs the stress suite on chromium in two shards - #572
Merged
Merged
Conversation
arrzdev
marked this pull request as ready for review
November 17, 2026 05:55
Owner
Author
|
Reviewed: the workflow change is correct and the dispatch run (44024358836) shows both stress shards green, with Checked:
Nits, not blocking. Leaving them for a follow-up:
Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stresssuite ran only in the Sundaye2e-fullmatrix, so a stress regression (the dev SSR socket reset, the WebKit reload failure) showed up a week late at best. The nightly ran only the five PR suites.What changes in
.github/workflows/e2e.yml:e2e-stress:test:e2e:stress --project=chromium, in two Playwright shards (--shard=n/2), on the nightly cron besidee2e. The suite is one worker by design and takes ~30 min in one job; per-file timings from the 2026-11-08 Sunday run put the split at ~16 / ~14 min, so the nightly's wall clock stays that ofe2e(~26 min). WebKit stays weekly.e2e. A red shard fails the scheduled run, which is what the existing failure monitoring already reads; nothing new to wire.workflow_dispatchgains ascopeinput:full(default, unchanged:e2e-full) ornightly(thee2eande2e-stressjobs on the dispatched ref), so the nightly set can be run on a branch.docs/guides/e2e.md,docs/guides/testing.md,docs/roadmap/open-questions.mdO11a,CLAUDE.md) say so.On Sundays chromium stress runs twice (03:00 nightly and 04:00 full). Left as is: the minutes are free on a public repo and the extra sample is useful.
Reproduce:
gh run list --workflow e2e.yml --event scheduleon main: no scheduled run before this PR has a stress job except the Sunday one.Verify:
gh workflow run e2e.yml --ref ci/nightly-stress-chromium -f scope=nightly→ https://github.com/arrzdev/adaptv/actions/runs/44024358836e2e-stress (chromium, 1/2): 116 tests, 115 passed (15.0m in Playwright), job 15.6 min, greene2e-stress (chromium, 2/2): 116 tests, 116 passed (15.2m), job 16.3 min, greene2e: 26.5 min, so the run's wall clock is 26.6 min (it was ~26 min before; the stress shards finish ~10 min earlier)e2e-full: skipped, as it should be forscope=nightlye2ewas red on one test, unrelated to this change (workflow-only diff):plain›wheel-column.spec.ts:259"a fast mouse fling coasts past where the pointer let go", the settle predicate timed out with 29 px left (≤ 1 expected). The same spec passed in the main suite of the same job. Tracked separately as a flake.python3 -c "import yaml; yaml.safe_load(open('.github/workflows/e2e.yml'))").Tested on: GitHub Actions
ubuntu-latest(dispatch above).Not tested: the
scheduletrigger itself (it fires only on main); the skip and issue steps are copied verbatim frome2e.