Repository navigation
ci(e2e): a nightly and a full dispatch on one ref both run, and a red night opens one issue - #576
Merged
Merged
Conversation
… night opens one issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups to #572 (nightly stress e2e).
Concurrency per scope. The
concurrency.groupofe2e.ymlwase2e-<ref>-workflow_dispatchfor every dispatch, so ascope=nightlydispatch and ascope=fulldispatch on the same ref cancelled each other. The group now ends with-<scope>for a dispatch. PR, schedule and push groups are unchanged (the suffix is empty wheninputs.scopeis unset).One issue per red night.
e2eand eache2e-stressshard had their own "open an issue" step, so a bad night opened up to three issues. Those steps are gone. A newnightly-issuejobneeds: [e2e, e2e-stress]and runsif: failure() && github.event_name == 'schedule', so it opens one issue that names the result of each job. I chose this over a "is there an open issue for this SHA" check: it has no race between shards finishing at the same time, needs no search, andissues: writenow lives on a single job that runs no repo code. A night skipped because main has not moved ends with every needed job green, sonightly-issuestays skipped.Doc wrap. The lines #572 edited in
CLAUDE.mdanddocs/guides/e2e.mdare rewrapped to ~100 columns. The wording is unchanged.Not changed: which suites run, and when.
Reproduce:
main, dispatche2e.ymlwithscope=nightlyon a branch, then withscope=fullon the same branch. The first run is cancelled.Verify:
gateon this PR: green.actionlint .github/workflows/e2e.yml(v1.7.7): no findings.scope=nightly: https://github.com/arrzdev/adaptv/actions/runs/44041587055 (success;nightly-issueskipped)scope=full: https://github.com/arrzdev/adaptv/actions/runs/44041601291 (success, 16/16 cells)awk 'length>100'on the rewrapped paragraphs: nothing over 101.Tested on: GitHub Actions (
workflow_dispatch, both scopes).Not tested: the
nightly-issuejob itself, which only runs onschedule. Its condition is the documentedfailure()withneeds:(true when any needed job failed).