Skip to content

fix: add missing RBS for direct connect DNS constants #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 1 commit into from
Oct 3, 2026
Merged

fix: add missing RBS for direct connect DNS constants #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Steepfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ target :lib do

# Standard libraries used in the project
library(
'forwardable'
'forwardable',
'ipaddr'
)
end
2 changes: 1 addition & 1 deletion lib/appium_lib_core/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def resolve_addresses(host)
return [normalized_host] if ip_literal?(normalized_host)

Timeout.timeout(DNS_RESOLVE_TIMEOUT_SECONDS) do
Socket.getaddrinfo(normalized_host, nil).map { |entry| entry[3] }.uniq
Socket.getaddrinfo(normalized_host, nil).map { |entry| entry[3].to_s }.uniq
end
rescue Timeout::Error
::Appium::Logger.warn("DNS resolution for '#{host}' timed out after #{DNS_RESOLVE_TIMEOUT_SECONDS}s")
Expand Down
12 changes: 12 additions & 0 deletions sig/lib/appium_lib_core/driver.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ module Appium

W3C_KEYS: Hash[String | Symbol, String]

DNS_RESOLVE_TIMEOUT_SECONDS: Integer

LOOPBACK_RANGES: Array[IPAddr]

LINK_LOCAL_RANGES: Array[IPAddr]

UNSPECIFIED_RANGES: Array[IPAddr]

MULTICAST_RANGES: Array[IPAddr]

DISALLOWED_RANGES: Array[IPAddr]

attr_reader protocol: String

attr_reader host: String
Expand Down
Loading