Repository navigation
fix: add missing RBS for direct connect DNS constants - #718
Merged
Merged
Conversation
Adds signatures for the new DirectConnections constants and loads ipaddr in the Steepfile, so steep is clean again.
aguspe
force-pushed
the
fix/rbs-direct-connect-dns
branch
from
October 3, 2026 14:11
2b24786 to
c4dbf87
Compare
aguspe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Steep was showing 24 warnings on master after the direct connect DNS changes (#678, #703), so this cleans them up:
ipaddrin the Steepfile soIPAddris foundDirectConnectionsconstants to the RBSto_son thegetaddrinfoentry so it matchesArray[String](it's always a String anyway, so no behavior change)Steep is clean again, and unit tests and rubocop stay green 🙂 Let me know if there is anything else I can help with!