Skip to content

fix: Change logo navigation to use client-side routing for same-site URLs #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raethlo wants to merge 2 commits into from
Closed

fix: Change logo navigation to use client-side routing for same-site URLs #2277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56cf4e1
fix: use client-side routing for logo link when on same origin
claude Feb 24, 2026
5ab9857
Merge branch 'master' into claude/fix-docs-logo-redirect-9WutP
raethlo Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions apify-docs-theme/src/theme/Logo/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,27 @@ function LogoThemedImage({ logo, alt, imageClassName }) {
}
export default function Logo(props) {
const {
siteConfig: { title },
siteConfig: { title, url: siteUrl, baseUrl: baseUrlConfig },
} = useDocusaurusContext();
const {
navbar: { title: navbarTitle, logo },
} = useThemeConfig();
const { imageClassName, titleClassName, ...propsRest } = props;
const logoLink = useBaseUrl(logo?.href || '/');
const homeLink = useBaseUrl('/');

// When the logo href points to the site's own URL (e.g. https://docs.apify.com
// on the docs.apify.com site), use client-side routing instead of a full page
// navigation. This avoids redirect issues when the site is served behind a
// reverse proxy (nginx -> GitHub Pages) where the upstream URL can leak through.
const siteOrigin = siteUrl?.replace(/\/$/, '');
const isOwnSiteUrl = logo?.href && siteOrigin
&& (logo.href === siteOrigin || logo.href === `${siteOrigin}/`)
&& baseUrlConfig === '/';

const resolvedLink = isOwnSiteUrl ? homeLink : logoLink;
const isExternalLink = !isOwnSiteUrl && /^https?:\/\//.test(resolvedLink);

// If visible title is shown, fallback alt text should be
// an empty string to mark the logo as decorative.
const fallbackAlt = navbarTitle ? '' : title;
Expand All @@ -45,7 +59,7 @@ export default function Logo(props) {
const alt = logo?.alt ?? fallbackAlt;
return (
<Link
to={logoLink}
{...(isExternalLink ? { href: resolvedLink } : { to: resolvedLink })}
{...propsRest}
{...(logo?.target && { target: logo.target })}>
{logo && (
Expand Down
Loading