fix: Change logo navigation to use client-side routing for same-site URLs#2277
Draft
fix: Change logo navigation to use client-side routing for same-site URLs#2277
Conversation
When the logo href matches the site's own URL (e.g. https://docs.apify.com on docs.apify.com), use React Router client-side navigation instead of a full page reload. This prevents the upstream GitHub Pages URL from leaking through the nginx reverse proxy, which caused users clicking the logo to be redirected to apify.github.io/apify-docs/apify-docs/ with broken CSS. For sub-sites (SDK, CLI, etc.) where baseUrl !== '/', the logo still performs a full page navigation to the main docs site as before. https://claude.ai/code/session_018xWQw8L3okDraDit7BYXHn
|
Preview for this PR was built for commit |
raethlo
changed the title
|
Preview for this PR was built for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preface: seems reasonable, but I am not sure at all if the fix is the correct thing to do 🕵🏻
When I click the logo in the API reference
I get a broken redirect to gh pages url (https://apify.github.io/apify-docs/apify-docs/)
Summary
https://claude.ai/code/session_018xWQw8L3okDraDit7BYXHn