Skip to content

feat(frontend): ask for the row details within the server's column limit #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aglinxinyuan merged 2 commits into from
Nov 5, 2026
Merged

feat(frontend): ask for the row details within the server's column limit #9242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e49b2
feat(frontend): ask for the row details within the server's column limit
kz930 Nov 1, 2026
90b65a3
Merge remote-tracking branch 'upstream/main' into feat/9241-row-detai…
kz930 Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions frontend/src/app/workspace/service/workflow-result/workflow-result.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import { TestBed } from "@angular/core/testing";
import {
ALL_COLUMNS,
OperatorPaginationResultService,
OperatorResultService,
WorkflowResultService,
Expand Down Expand Up @@ -474,6 +475,15 @@ describe("OperatorPaginationResultService", () => {
expect((service as any).pendingRequests.size).toBe(0);
});

it("asks for every column within the server's Int when no column limit is given", () => {
service.selectPage(3, 10).subscribe();

expect(mockWorkflowWebsocketService.send).toHaveBeenCalledWith(
"ResultPaginationRequest",
expect.objectContaining({ columnLimit: ALL_COLUMNS })
);
});

it("bypasses the frontend cache when column filters are set", () => {
(service as any).resultCache.set(2, [{ id: 1 }]);
service.selectPage(2, 10, 5).subscribe();
Expand Down
11 changes: 8 additions & 3 deletions frontend/src/app/workspace/service/workflow-result/workflow-result.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,12 @@ export class OperatorResultService {
}
}

/**
* A column limit that asks for every column. The server reads the limit as a 32-bit Int, so it is
* Int.MaxValue there; Number.MAX_SAFE_INTEGER fails to parse and the request is never answered.
*/
export const ALL_COLUMNS = 2147483647;

export class OperatorPaginationResultService {
private pendingRequests: Map<string, Subject<PaginatedResultEvent>> = new Map();
private resultCache: Map<number, ReadonlyArray<object>> = new Map();
Expand Down Expand Up @@ -317,14 +323,13 @@ export class OperatorPaginationResultService {
pageIndex: number,
pageSize: number,
columnOffset: number = 0,
columnLimit: number = Number.MAX_SAFE_INTEGER,
columnLimit: number = ALL_COLUMNS,
columnSearch: string = ""
): Observable<PaginatedResultEvent> {
// update currently selected page
this.currentPageIndex = pageIndex;
// first fetch from frontend result cache
const useCache =
this.portIndex === 0 && columnOffset === 0 && columnLimit === Number.MAX_SAFE_INTEGER && columnSearch === "";
const useCache = this.portIndex === 0 && columnOffset === 0 && columnLimit === ALL_COLUMNS && columnSearch === "";
const pageCache = useCache ? this.resultCache.get(pageIndex) : undefined;
if (pageCache) {
return of(<PaginatedResultEvent>{
Expand Down
Loading