Repository navigation
feat(frontend): ask for the row details within the server's column limit - #9242
Merged
aglinxinyuan merged 2 commits intoNov 5, 2026
Merged
Conversation
selectPage defaulted its column limit to Number.MAX_SAFE_INTEGER, which the server cannot read as an Int, so a request that left it out was never answered and was recorded as a compilation error. The Row Details modal and report generation both leave it out. The default is now ALL_COLUMNS, Int.MaxValue, and the page cache is keyed by the same value. Closes apache#9241. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9242 +/- ##
============================================
- Coverage 92.17% 92.05% -0.13%
+ Complexity 5043 4988 -55
============================================
Files 1287 1285 -2
Lines 55799 55662 -137
Branches 7144 7124 -20
============================================
- Hits 51434 51239 -195
- Misses 2598 2673 +75
+ Partials 1767 1750 -17
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
carloea2
approved these changes
Nov 4, 2026
carloea2
left a comment
carloea2
left a comment
Contributor
There was a problem hiding this comment.
The request default and cache key match the server limit. All 16 focused checks pass, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
selectPagedefaulted its column limit toNumber.MAX_SAFE_INTEGER, which the server cannot read as an Int, so a request that left it out was never answered and was recorded as a compilation error. The Row Details modal and report generation both leave it out. The default is nowALL_COLUMNS, which is Int.MaxValue, and the page cache is keyed by the same value.Any related issues, documentation, discussions?
Closes #9241. Found in the review of #9058, which uses the same value for its hover preview.
How was this PR tested?
A new
workflow-result.service.spec.tscase checks that a page asked for without a column limit sendsALL_COLUMNS, and the existing cache case still passes on the default. In the running app, Row Details shows the clicked row and no error is recorded.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code